jcuenod / craftbrew Goto Github PK

How about being able to tab through alternative possibilities at any time?

Well at the very least it's inconsistent.

Can accents go on these characters?

i.e. should we ban both or allow both?

Sometimes a single hit doesn't register but a double hit registers twice.
This happens both inserting and deleting.

We now have the backend to support backspacing multiple characters based on what was last inserted so why not add shuruq to "u"?

Type "y", "o", "z" -> backspace -> tab
The "o" is promoted to a tzadi because lastcode is not cycled backwards.

We probably need an undo redo type of thing.

Not ideal to clear the whole page when there is an actual selection.

When hitting tab or cycling through things sometimes all the text seems randomly to disappear.

when you type an accent first (lamed, accent, dagesh, hireq -> now backspace...)

When selecting, if you hit "ctrl+c" it behaves as though "c" was hit and does not seem to copy the text to the clipboard.
It may be useful to copy the entire script but it may also be useful to make it selectable.

Sometimes after backspacing something and promoting, a very strange promotion will happen. I'm not sure how to reproduce this though. Needs testing which I don't have time for right now.

selecting the text goes in a dumb direction (almost like rtl is not enabled

Try "m" -> "." -> "o"
Now hit tab a bunch of times and see the strangeness that results...

If you add a Holem Waw to the end of a word, the final character doesn't change form (Probably just need to add the character to a regex or something).

It's pointless allowing them so may as well ban them.

Should we ban the dagesh on gutturals. Maybe it's useful but maybe not...

Rather than selecting the final form, when space is hit, it could be automatically converted.

That can't happen (I don't think). There are probably a bunch of impossible combinations worth being aware of and filtering against.

We only allow for spaces - we should allow for maqafs

When the character doesn't change if you hit the same key, it should be duplicated (rather than waiting for the timeout). This is true for all keycodes that only map to one character (which is a surprising number):

"B": ["ב"],
"D": ["ד"],
"E": ["א"],
"F": ["פ"],
"G": ["ג"],
"I": ["י"],
"J": ["י"],
"L": ["ל"],
"M": ["מ"],
"N": ["נ"],
"P": ["פ"],
"Q": ["ק"],
"R": ["ר"],
"U": ["וּ"],
"X": ["א"],
"Y": ["י"],

It would be better to assume that it's a final form and then change based on whether it's the last letter or not (in other words, regularly check the last two consonants for final form appropriateness).

Consider typing lmc:

lm => l, final m
lmc => lm, final c