jcostom / ddnsup Goto Github PK

Great work; best I've found.

For DNS-0-Matic, there are undefined variables in ddnsup.py. Correcting the following lines resolves the issue and the record updates correctly.

DOM_USER = os.getenv('DOM_USER')
DOM_PASSWD = os.getenv('DOM_PASSWD')
DOM_WILDCARD = os.getenv('DOM_WILDCARD', 'NOCHG')
DOM_MX = os.getenv('DOM_MX', 'NOCHG')
DOM_BACKUPMX = os.getenv('DOM_BACKUPMX', 'NOCHG')`

Side note:
OpenDNS credentials are required. I signed up a long time ago and had DNS-O-Matic credentials. I feel it may help to mention that.

Hey, first of all, thanks a lot for making this!

Docker provides a mechanism for secret management, but it takes file_paths to read the values from.
Would it be possible to have the secrets also have an option to read from a path.
like adding API_KEY_PATH, and the script would read the value from a file path supplied ?
(incidentally systemd has a very similar system).

happy to give details on anything.

example-dnsomatic-docker-compose.yaml.

Only to include the rest of the useable variables. Not "needed", as they do populate by ddnsup.py. This is only for reference in case they need to be used by others, saving time discovering them within ddnsup.py.

Also disabled Telegram by default, and noted OpenDNS credentials are required (For legacy users with DNS-O-Matic credentials) that I mentioned in my other submitted issue. I feel these changes will make it easier/faster to deploy.

environment:
  - PROVIDER=dnsomatic
  - DOM_USER=my-opendns-username
  - DOM_PASSWD=my-opendns-password
  - DOM_MX=NOCHG
  - DOM_BACKUPMX=NOCHG
  - DOM_WILDCARD=NOCHG
  - RECORDS=list,of,hostnames,you,are,updating
  - USETELEGRAM=0
  - CHATID='Your Telegram Chat ID'
  - MYTOKEN='Your Telegram Bot Token'
  - SITENAME='Your Site Identifier'
  - TZ=America/New_York # or whatever makes sense for you

Thanks again for all your work!