jconroy77 / protobuf-wireshark Goto Github PK

Wireshark cannot load multiple auto-generated dissectors.

Reason: They all share the same protocol abbreviation.

Will be fixed in the next release.

Hi

I've tried to compile protobuf-wireshark-runtime-0.1
followed by instructions from README.txt
Wireshark version 1.9.0, rev 47629
Linux: Debian GNU/Linux 6.0.6 (squeeze), kernel: 2.6.32-5-686

libprotobuf6       - 2.3.0-4
libprotobuf-dev    - 2.3.0-4
libprotobuf-lite6  - 2.3.0-4

Wireshark itself well compiles and installs.

Troubles with wireshar-protobuf plugin:

make: *** No targets specified and no makefile found. Stop.
Unable to compile wireshark plugin in /home/igor/Dev/wireshark/plugins/protobuf

the paths in wireshark.conf and addressbook.conf set properly (corresponding to 
files location)

contents of wireshark/plugins/protobuf folder:
-rw-r--r-- 1 root root    536 Feb 11 08:43 Makefile.am
-rw-r--r-- 1 root root    253 Feb 11 08:43 moduleinfo.h
-rw-r--r-- 1 root root   5414 Feb 11 08:43 packet-protobuf.c
-rw-r--r-- 1 root root 577308 Feb 11 08:44 wireshark-glue-protobuf.o

how to enforce it to generate Makefile from Makefile.am ?

Regards,
Igor.

Protobuf is a popular wire data format. It appears that the majority of the 
issues for this project are related to people trying to compile and use this. 
It would be of large benefit to Protobuf and Wireshark users if this dissector 
plugin were included in the upstream project. Is there any interest in doing 
this and/or has this been discussed before?

I imagine this work would involve:

1) Review license compatibility between this project (Apache License 2.0) and 
the upstream Wireshark (GPL 2) 

http://www.apache.org/licenses/GPL-compatibility.html
https://www.gnu.org/licenses/license-list.html#apache2

From what I can tell this project would need to be re-licensed before the code 
can be contributed to Wireshark.

2) Contribute the code to Wireshark. This may require refactoring and/or misc 
tidying of the project according to upstream conventions.

https://www.wireshark.org/docs/wsdg_html_chunked/ChSrcContribute.html#ChSrcSend


What do you think?

It would be great if this worked for TCP streams with messages prefixed by
message length.

What steps will reproduce the problem?
1. Create config file for plugin
2. run make_wireshark_plugin.py

What is the expected output? What do you see instead?
Expected output would be a compiled plugin. Instead we get an error about not 
being able to find configure.in

What version of the product are you using? On what operating system?
Wireshark 1.10.8, protobuf-wireshark 0.5, Ubuntu 14.04

Please provide any additional information below.

Though configure.in does not exist, there is a file called configure.ac

What steps will reproduce the problem?
1. patch http://code.google.com/p/protobuf-wireshark/issues/detail?id=9
2. compile against wireshark-1.10.5

  CC       packet-protobuf.lo
packet-protobuf.c: In function 'proto_register_protobuf':
packet-protobuf.c:70:9: error: too many arguments to function 
'get_persconffile_path'
         dirname = get_persconffile_path("protobuf", FALSE, FALSE);
         ^
In file included from packet-protobuf.c:9:0:
../../epan/filesystem.h:197:21: note: declared here
 WS_DLL_PUBLIC char *get_persconffile_path(const char *filename, gboolean from_profile);
                     ^
packet-protobuf.c:60:12: warning: variable 'protobuf_module' set but not used 
[-Wunused-but-set-variable]
  module_t *protobuf_module;
            ^
packet-protobuf.c: In function 'wireshark_pb_process_protobuf_register_subtree':
packet-protobuf.c:152:31: warning: request for implicit conversion from 'void 
*' to 'struct hf_register_info *' not permitted in C++ [-Wc++-compat]
   hf_register_info *hf_info = malloc(sizeof( hf_register_info ) );
                               ^
packet-protobuf.c: In function 'wireshark_pb_process_protobuf_register_field':
packet-protobuf.c:173:27: warning: enum conversion in initialization is invalid 
in C++ [-Wc++-compat]
                           type,
                           ^
packet-protobuf.c:173:27: warning: (near initialization for 
'message_info.hfinfo.type') [-Wc++-compat]
packet-protobuf.c:181:31: warning: request for implicit conversion from 'void 
*' to 'struct hf_register_info *' not permitted in C++ [-Wc++-compat]
   hf_register_info *hf_info = malloc(sizeof( hf_register_info ) );
                               ^
make: *** [packet-protobuf.lo] Error 1
Unable to compile wireshark plugin in /tmp/wireshark-1.10.5//plugins/protobuf
f

Hello there,

that's a pretty useful wireshark plugin. Nice ! 

But I was wondering, if it is technically possible to integrate it differently 
in wireshark :
 1- Install the (new) plugin only once in the wireshark directory.
 2- In the decode as menu, at transport level, you select PROTOCOL_BUFFERS 
    for instance.
 3- The user is prompted for the .proto file to use (and additional info)
 4- The decoding is then applied automatically.

I am not a wireshark developer, but a wireshark user ;). And I believe it 
would be nicer to have it this way.

This said, I hope you take it as it is, a constructive remark. 
Because it's true that it's open source and I may code it myself!
But fore sure, it would take me more time to get familiar with the 
wireshark development...

Cheers,
Roudy 

I am getting an error where . / c++ is not recognized  as a internal or 
external command.

Here is the output:

make_wireshark_plugin.py iudp.conf
Generating Wireshark plugin for  iUDP
Generating  C:\CR1\source\Wireshark/plugins/iUDP/packet-iUDP.c
Generating  C:\CR1\source\Wireshark/plugins/iUDP/Makefile.am
Generating  C:\CR1\source\Wireshark/plugins/iUDP/moduleinfo.h
Generating  C:\CR1\source/wireshark-glue-iUDP.cc
Generating  C:\CR1\source/wireshark-glue-iUDP.h
plugins/iUDP/Makefile already present in configure.in
iUDP already present in plugins/Makefile.am
'.' is not recognized as an internal or external command,
operable program or batch file.
'.' is not recognized as an internal or external command,
operable program or batch file.
'c++' is not recognized as an internal or external command,
operable program or batch file.
Unable to compile wireshark-glue-iUDP.cc

c:\CR1\source\WIRESHARK TOOLS\protobuf-wireshark\iudp>


What version of the product are you using? On what operating system?
I have build the wireshark sources (1.9.1)
I have configured the .conf file point to the correct locations.
I am running on Windows 7, have Visual Studio 2010.

First issue
*make_wireshark_plugin.py issue
*I had an error where it could not open 'configure.in' and I saw the issue  
*opened where this was fixed by changing it to configure.ac

What steps will reproduce the problem?
1. Generate messages with repeated fields of primitive type

What is the expected output? What do you see instead?
Dissector should display these fields too. Instead the Dissector crashed

Please use labels and text to provide additional information.

I want to use the protobuf-wireshark under Mac OS 10.7 to debug our program. 
However, the protobuf-wireshark cannot build in it.

I downloaded the "protobuf-wireshark-runtime-0.1" and run the 
"./make_wireshark_plugin.py". It complained:
==================================================
/bin/sh ../../libtool  --tag=CC   --mode=link gcc  -DINET6 -no-cpp-precomp 
-D_U_="__attribute__((unused))" -g -O2 -Wall -W -Wextra 
-Wdeclaration-after-statement -Wendif-labels -Wpointer-arith -Wno-pointer-sign 
-Wcast-align -Wformat-security -I/usr/local/include -D_REENTRANT 
-I/opt/local/include/gtk-2.0 -I/opt/local/lib/gtk-2.0/include 
-I/opt/local/include/atk-1.0 -I/opt/local/include/cairo 
-I/opt/local/include/gdk-pixbuf-2.0 -I/opt/local/include/pango-1.0 
-I/opt/local/include/gio-unix-2.0/ -I/opt/local/include 
-I/opt/local/include/glib-2.0 -I/opt/local/lib/glib-2.0/include 
-I/opt/local/include/pixman-1 -I/opt/local/include/freetype2 
-I/opt/local/include/libpng14     -module -avoid-version -shared 
-Wl,-soname,protobuf.so -o protobuf.so -Wl,-search_paths_first  
-L/usr/local/lib -L/usr/local/lib -L/usr/local/lib -L/usr/local/lib 
-L/usr/local/lib -o protobuf.la -rpath 
/Users/wangqi/disk/projects/snsgames/babywar/thirdparty/wireshark/bin/lib/wiresh
ark/plugins/1.6.3 packet-protobuf.lo  wireshark-glue-protobuf.o -lprotobuf

*** Warning: Linking the shared library protobuf.la against the non-libtool
*** objects  wireshark-glue-protobuf.o is not portable!
libtool: link: rm -fr  .libs/protobuf.la .libs/protobuf.lai
libtool: link: gcc -Wl,-undefined -Wl,dynamic_lookup -o .libs/protobuf.so 
-bundle  .libs/packet-protobuf.o  wireshark-glue-protobuf.o   -L/usr/local/lib 
/usr/local/lib/libprotobuf.dylib -lz  -O2 -Wl,-soname -Wl,protobuf.so 
-Wl,-search_paths_first  
ld: unknown option: -soname
collect2: ld returned 1 exit status
make: *** [protobuf.la] Error 1
Unable to compile wireshark plugin in 
/Users/wangqi/disk/projects/snsgames/babywar/thirdparty/wireshark/src/plugins/pr
otobuf

======================================================

Then I modified the Makefile.am.template, change the line:
|PLUGIN_NAME|_la_LDFLAGS = -module -avoid-version -shared 
-Wl,-soname,|PLUGIN_NAME|.so -o |PLUGIN_NAME|.so
to 
|PLUGIN_NAME|_la_LDFLAGS = -module -avoid-version -shared -o |PLUGIN_NAME|.so

This time it can compile but throw a warning:

======================================================
/bin/sh ../../libtool  --tag=CC   --mode=link gcc  -DINET6 -no-cpp-precomp 
-D_U_="__attribute__((unused))" -g -O2 -Wall -W -Wextra 
-Wdeclaration-after-statement -Wendif-labels -Wpointer-arith -Wno-pointer-sign 
-Wcast-align -Wformat-security -I/usr/local/include -D_REENTRANT 
-I/opt/local/include/gtk-2.0 -I/opt/local/lib/gtk-2.0/include 
-I/opt/local/include/atk-1.0 -I/opt/local/include/cairo 
-I/opt/local/include/gdk-pixbuf-2.0 -I/opt/local/include/pango-1.0 
-I/opt/local/include/gio-unix-2.0/ -I/opt/local/include 
-I/opt/local/include/glib-2.0 -I/opt/local/lib/glib-2.0/include 
-I/opt/local/include/pixman-1 -I/opt/local/include/freetype2 
-I/opt/local/include/libpng14     -module -avoid-version -shared -o protobuf.so 
-Wl,-search_paths_first  -L/usr/local/lib -L/usr/local/lib -L/usr/local/lib 
-L/usr/local/lib -L/usr/local/lib -o protobuf.la -rpath 
/Users/wangqi/disk/projects/snsgames/babywar/thirdparty/wireshark/bin/lib/wiresh
ark/plugins/1.6.3 packet-protobuf.lo  wireshark-glue-protobuf.o -lprotobuf

*** Warning: Linking the shared library protobuf.la against the non-libtool
*** objects  wireshark-glue-protobuf.o is not portable!
libtool: link: gcc -Wl,-undefined -Wl,dynamic_lookup -o .libs/protobuf.so 
-bundle  .libs/packet-protobuf.o  wireshark-glue-protobuf.o   -L/usr/local/lib 
/usr/local/lib/libprotobuf.dylib -lz  -O2 -Wl,-search_paths_first  
libtool: link: ( cd ".libs" && rm -f "protobuf.la" && ln -s "../protobuf.la" 
"protobuf.la" )
======================================================

However, the wireshark 1.6.3 cannot start now.

======================================================
$ ./wireshark 
wireshark(32924,0x7fff7b9de960) malloc: *** error for object 
0xffffffffaaa2f5f0: pointer being freed was not allocated
*** set a breakpoint in malloc_error_break to debug
Abort trap: 6
======================================================


How can I run this problem in Mac. It's really important for me to develop. 
Thanks a lot!

What steps will reproduce the problem?
1. Download win 32 wire shaark
2. Install win 32 wireshark
3. Try to find protobuf plugin dll for wireshark

What is the expected output? What do you see instead?

plugin dll found in downloads

What version of the product are you using? On what operating system?

Wireshark 1.6.5

Please provide any additional information below.

Ubuntu 9.04
Wireshark 1.2.2
Protobuff 2.0.3-2.2
protobuf-wireshark 0.2

I followed B. Generic Message Dissector

Cannot compile. Here is error:
*** Warning: Linking the shared library GoogleProtoBuf.la against the
non-libtool
*** objects  wireshark-glue-GoogleProtoBuf.o is not portable!
libtool: link: gcc -shared  .libs/packet-GoogleProtoBuf.o 
wireshark-glue-GoogleProtoBuf.o   -L/usr/local/lib /usr/lib/libprotobuf.so
 -pthread -Wl,-soname -Wl,GoogleProtoBuf.so   -pthread -Wl,-soname
-Wl,GoogleProtoBuf.so -o .libs/GoogleProtoBuf.so
libtool: link: ( cd ".libs" && rm -f "GoogleProtoBuf.la" && ln -s
"../GoogleProtoBuf.la" "GoogleProtoBuf.la" )
Unable to compile wireshark plugin in
/home/iron/temp/wireshark-1.2.2/plugins/GoogleProtoBuf

What steps will reproduce the problem?

1. start wireshark (built from source)


What is the expected output? What do you see instead?

I expect to see no errors from the protobuf-wireshark dissector.

Instead I see:

filename to import /home/chris/protobuf/pbtest/src/addressbook.proto
Error in file /home/chris/protobuf/pbtest/src/addressbook.proto at 
line/col:-1/0File not found.
Unable to parse /home/chris/protobuf/pbtest/src/addressbook.proto
Couldnt get descriptor from addressbook.conf

and the dissector does not work.


What version of the product are you using? On what operating system?

protobuf-wireshark-runtime-0.1
libprotoc 2.4.1
wireshark 1.6.4


Please provide any additional information below.


Here is the console...

chris@chris-linux-desktop:~/protobuf/wireshark$ bin/wireshark
filename to import /home/chris/protobuf/pbtest/src/addressbook.proto
Error in file /home/chris/protobuf/pbtest/src/addressbook.proto at 
line/col:-1/0File not found.
Unable to parse /home/chris/protobuf/pbtest/src/addressbook.proto
Couldnt get descriptor from addressbook.conf

// Wireshark GUI appears at this point... exit manually.

chris@chris-linux-desktop:~/protobuf/wireshark$ ls -lA 
/home/chris/protobuf/pbtest/src/addressbook.proto
-rw-r--r-- 1 chris chris 472 2012-01-03 10:56 
/home/chris/protobuf/pbtest/src/addressbook.proto

chris@chris-linux-desktop:~/protobuf/wireshark$ cat 
/home/chris/protobuf/pbtest/src/addressbook.proto
package tutorial;

option java_package = "pbtest";
option java_outer_classname = "AddressBookProtos";

message Person {
  required string name = 1;
  required int32 id = 2;
  optional string email = 3;

  enum PhoneType {
    MOBILE = 0;
    HOME = 1;
    WORK = 2;
  }

  message PhoneNumber {
    required string number = 1;
    optional PhoneType type = 2 [default = HOME];
  }

  repeated PhoneNumber phone = 4;
}

message AddressBook {
  repeated Person person = 1;
}