Comments (9)
Hi!
I'v changed the Header to the more standard Authentication-Results.
I can add an adicional config key to add, also the Received-SPF.
Do you think its worth it ?
from smf-spf.
Found, that old code uses "Received-SPF:", but new code uses "Authentication-Results:" but this is not documented in config, and config example is still "Build a standard Received-SPF: header".
However, I think that the word "Authentication" is misleading, as no authentication is done.
Changing the header name, via config file would be nice to have.
from smf-spf.
Hehehe . There was ( and still is ) a long discussing about that wording but that's what is in the RFC 7601.
Anyway, I will update de documentation and config.
Note : I'm not the original author of the milter. I just added some public patches and did some bug fix and some enhancements.
from smf-spf.
Ok, but what was the reason for changing/shortening the header content?
New:
Authentication-Results: xxx.domain.com; spf=pass smtp.mailfrom=[email protected] smtp.helo=github-smtp2b-ext-cp1-prd.iad.github.net
Old:
Received-SPF: Pass (xxx.domain.com: domain of bounce-mc.us11_46716125.696461-xxx=[email protected]
designates 198.2.131.14 as permitted sender)
receiver=xxx.domain.com; client-ip=198.2.131.14;
envelope-from=[email protected]; helo=mcmail.github.com;
Old is maybe too long, but new is maybe too short, and the result "spf=pass" is in not the first word, so I have to search for it. So, maybe something like (no need for extra word smtp as this is the smtp traffic):
Authentication-Results: spf=pass; receiver=xxx.domain.com; mailfrom=[email protected]; helo=github-smtp2b-ext-cp1-prd.iad.github.net;
from smf-spf.
Anyway, the old code segfaults was for me the main reason to test this version. I can change the header in smf-spf.c directly according to my needs. So thanks for keeping this code alive.
from smf-spf.
@ksuuk , check if PR #32 works for you.
from smf-spf.
Tested and works fine, thanks.
from smf-spf.
Great.
I'll keep this open until I add some tests. That won't happen in the next week.
Additionally, I'll add an option to remove all Received-SPF headers.
One advantage of Authentication-Results over Received-SPF is that the hostname of the servers that make the evaluation. This will be more relevant when ARC become a standard.
from smf-spf.
Closing this issue
from smf-spf.
Related Issues (20)
- New feature: Reject at SPF None results HOT 7
- Reject bounces when SPF fails
- Choose hard or soft fail when rejecting bounces
- Reject bounces when there is no SPF policy defined HOT 1
- Only domain size is checked HOT 1
- Disable localpart size check HOT 1
- Typos
- Add SPF best guess
- `smf-spf -f` does not override config file value `Daemonize` HOT 3
- Make SPF evaluation with a fixed IP HOT 1
- use application name in syslog HOT 1
- Allow logging to file without syslog HOT 3
- ClientIPNat will not work if FixedIP is set.
- Skip authenticated messages HOT 1
- Config value with spaces are ignore
- Compile failure on Debian HOT 1
- New version scheduled?
- RejectReason URL and parameters issue HOT 6
- Deprecated DNS record type of SPF (type 99) issue. HOT 8
- Authentication-Results header - wrong position HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from smf-spf.