Comments (8)
The milter uses libspf2 that has that actually does the lookup.
Debian and Ubuntu already removed that in 2014
libspf2 (1.2.10-5) unstable; urgency=low
* abolish-spf-rrtype.patch: Stop trying to look up the dedicated SPF DNS
RR type, which was abolished by RFC 7208 (Closes: #764533).
* Bump Standards-Version to 3.9.6.
What distro do you use?
from smf-spf.
What distro do you use?
cat /etc/redhat-release
CentOS Linux release 7.9.2009 (Core)
rpm -qa | grep libspf2
libspf2-devel-1.2.10-5.20150405gitd57d79fd.el7.x86_64
libspf2-1.2.10-5.20150405gitd57d79fd.el7.x86_64
The patch http://svn.kibibyte.se/libspf2/tags/1.2.10-7/debian/patches/abolish-spf-rrtype.patch?rev=96 does:
/* I am VERY, VERY sorry about the gotos. Shevek. */
- rr_type = ns_t_spf;
+ rr_type = ns_t_txt;
Damn Redhat, as Centos 7/8 libspf2 is not patched and still contains:
/* I am VERY, VERY sorry about the gotos. Shevek. */
rr_type = ns_t_spf;
Seems I must patch and build my own libspf2 package - done, testing now.
BTW, as smf-spf uses shared libspf2 libraries, so there is no need to rebuild also smf-spf, correct?
from smf-spf.
Correct.
I've also tested to rebuild with that patch and worked ok.
Just added
Patch4: 0004-abolish-spf-rrtype.patch
to the spec file and threw the patch to SOURCE dir as 0004-abolish-spf-rrtype.patch
from smf-spf.
Correct.
I've also tested to rebuild with that patch and worked ok.
Just addedPatch4: 0004-abolish-spf-rrtype.patch
to the spec file and threw the patch to SOURCE dir as 0004-abolish-spf-rrtype.patch
Just curious, what are the patches 1-3?
from smf-spf.
Not sure but looks like distro-specific adjustments
from smf-spf.
Not sure but looks like distro-specific adjustments
What distro are You using?
And BTW, I have some old server, which could not build newer than v2.4.3 version, so I made patch for it, maybe it's useful for some other also:
--- smf-spf.c-orig 2020-11-12 23:44:00.000000000 +0200
+++ smf-spf.c 2021-09-04 21:48:36.000000000 +0300
@@ -197,7 +197,7 @@
static int foreground = 0;
static config conf;
static char *daemon_name;
-static char hostname[HOST_NAME_MAX+1];
+static char hostname[256];
static pid_t mypid = 0;
static pthread_mutex_t cache_mutex;
static facilities syslog_facilities[] = {
@@ -1234,7 +1234,7 @@
strHelper[(strlen(strHelper) - 1)] = '\0';
(daemon_name = strrchr(strHelper, '/')) ? ++daemon_name : (daemon_name = strHelper);
- gethostname(hostname,HOST_NAME_MAX+1);
+ gethostname(hostname, 255);
while ((ch = getopt(argc, argv, "fhc:")) != -1) {
switch (ch) {
from smf-spf.
I use Ubuntu LTS since 16.04.
For that issue, please open a different issue with more details of your system, including the centos version so I can replicate.
from smf-spf.
For that issue, please open a different issue with more details of your system, including the centos version so I can replicate.
Nevermind, this RedHat based ancient remote server just didn't support "gethostname(hostname,HOST_NAME_MAX+1)" function, so I made workaround, and there is no need to deal more deeply with it.
from smf-spf.
Related Issues (20)
- New feature: Reject at SPF None results HOT 7
- Reject bounces when SPF fails
- Choose hard or soft fail when rejecting bounces
- Reject bounces when there is no SPF policy defined HOT 1
- Only domain size is checked HOT 1
- Disable localpart size check HOT 1
- Typos
- Add SPF best guess
- `smf-spf -f` does not override config file value `Daemonize` HOT 3
- Make SPF evaluation with a fixed IP HOT 1
- use application name in syslog HOT 1
- Allow logging to file without syslog HOT 3
- ClientIPNat will not work if FixedIP is set.
- Skip authenticated messages HOT 1
- Config value with spaces are ignore
- Compile failure on Debian HOT 1
- New version scheduled?
- RejectReason URL and parameters issue HOT 6
- Authentication-Results header - wrong position HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from smf-spf.