jbreckel / flow-result-checker Goto Github PK

Hey there. I want to try your filter for flow output, looks promising. But I faced a problem when using styled-components. So if I added it go [ignore] section of .flowconfig, there are no errors. But if it's not there, I receive very strange output:

Found 0 errors


             ^^^^^^^^^^^^ See type parameters of definition here. See lib: /private/tmp/flow/flowlib_2d1625c3/react.js:29

Found 1 error

As you see, there are even no any explaining error messages. Do you have any ideas about what can cause such behaviour? Thanks.

read quiet and include option from .flowconfig as proposed for flow in facebook/flow#869 (comment)

If there are more then 50 errors are found flow will additionally print

'\n... 2 more errors (only 50 out of 52 errors displayed)\nTo see all errors, re-run Flow with --show-all-errors\n'

into the stdout. As this is not filtered out the result list has a length on one and the process exits with 1. Solution: always run flow with --show-all-errors

Please update the readme with sample usage. Currently trying to use this script results in

Skipping /repository/flow/: No such file or directory

and it's unclear whether it's due to a bug or my own misuse.

The bug title is probably self-explanatory. The modified error format in Flow 0.65 is not recognised by flow-result-checker.

flow check --quiet --show-all-errors | flow-result-checker

Error --------------------------------------------------------------- node_modules/@client/immutable/immutable.js:268:13

Cannot call `setIn` with `path` bound to `path` because string [1] is incompatible with number [2] in array element.

   node_modules/@client/immutable/immutable.js:268:13
   268| 		setIn(ob, path, val);
                    ^^^^

References:
   node_modules/@client/immutable/immutable.js:265:45
   265| function setDeepIn<T>(ob: T & Object, path: string[], val: any): T {
                                                    ^^^^^^ [1]
   node_modules/timm/src/timm.js:380:61
   380| export function setIn<T: ArrayOrObject>(obj: T, path: Array<Key>, val: any): T {
                                                                    ^^^ [2]

Found 4 errors

We're hitting this error. There's a clash between types in flow-typed. The errors are like:

[No file]:0
inconsistent use of library definitions

I manually patched the checker.js file to test for [No file] and ignroe those lines as well as those starting node_modules.

Any interest in adding an option to specify additional patterns to ignore?

If you don't have any errors in node_modules you're presented with an error.