jbech-linaro / ibart Goto Github PK
View Code? Open in Web Editor NEWI Build And Run Tests! Automatic testing of software (and hardware) from GitHub pull requests
License: MIT License
I Build And Run Tests! Automatic testing of software (and hardware) from GitHub pull requests
License: MIT License
In some cases it's convenient to put the job definition directly into the git tree, i.e., similar to what you can do with Travis and Shippable. Having this in IBART would probably be useful and can help GitHub project owner writing and testing their own job-definitions.
1: IBART $
<EVEL=1 CFG_LOCKDEP=y CFG_CORE_MBEDTLS_MPI=y;echo $?
2: mkdir -p /home/optee/devel/hikey/build/../out
echo $?
does not display 0
before line 2The first point is the real issue because it makes it impossible to know which build flags have been set, and therefore to reproduce the build locally.
Suggested by Jerome.
The commit message in pull request OP-TEE/optee_os#2485 generates a webhook payload containing
"body": "When processing the source files for an in-tree user TA (ta/*/user_ta.mk),\r\nmake sure not to insert a double slash in the object file path.\r\n\r\nFixes the following error:\r\n\r\n $ make -s\r\n $ make clean\r\n CLEAN out/arm-plat-vexpress\r\n rmdir: failed to remove 'out/arm-plat-vexpress/ta/avb': No such file or directory\r\n Makefile:98: recipe for target 'clean' failed\r\n make: *** [clean] Error 1\r\n\r\nThe error results from the fact that we have two kinds of object files in\r\nthe in-tree TAs:\r\n - The object files built from ta/*/user_ta.mk. For AVB, we have\r\n out/arm-plat-vexpress/ta/avb//entry.o (notice the repeated slash).\r\n - The object files that correspond to \"specified source files\", i.e.,\r\n constructed from $(spec-out-dir) and $(spec-srcs). For AVB we have\r\n out/arm-plat-vexpress/ta/avb/user_ta_header.o.\r\nWhen \"make clean\" creates the list of directories to be removed, it strips\r\nthe /filename part and keeps only the directory part, resulting in:\r\n\r\n rmdir ... out/arm-plat-vexpress/ta/avb/ out/arm-plat-vexpress/ta/avb\r\n\r\nTrying to remove the same directory twice: \"No such file or directory\".\r\n\r\nFixes: https://github.com/OP-TEE/optee_os/issues/2484\r\nSigned-off-by: Jerome Forissier <[email protected]>\r\n\r\n<!--\r\n If you are new to submitting pull requests to OP-TEE, then please have a\r\n look at the list below and tick them off before submitting the pull request.\r\n\r\n 1. Read our contribution guidelines:\r\n documentation/github.md.\r\n\r\n 2. Read the contribution section in Notice.md and pay extra attention to the\r\n \"Developer Certificate of Origin\" part:\r\n https://github.com/OP-TEE/optee_os/blob/master/Notice.md#contributions.\r\n\r\n 3. You should run checkpatch preferably before submitting the pull request.\r\n\r\n 4. When everything has been reviewed, you will need to squash, rebase and\r\n add tags like `Reviewed-by`, `Acked-by`, `Tested-by` etc.\r\n\r\n NOTE: This comment will not be shown in the pull request, so no harm keeping\r\n it, but feel free to remove it if you like.\r\n-->\r\n",
where part of this commit message is saying:
... failed to remove 'out/arm-plat-vexpress/ta/avb': No such ...
The single quotes here terminates the SQL query here incorrectly and therefore fails to store a record.
To fix this error and prevent an eventual SQL injection attack one needs to sanitize the input.
At each individual job there is the name of the branch and it is linked. However, the link points to the upstream optee_os git and not the submitters git and hence we will get a bad (404) URL.
Flask is not meant to be used as a public server, instead use a real webserver. More about how to do that can be found here: http://flask.pocoo.org/docs/1.0/tutorial/deploy/
Suggested by Jerome. This is an extension to the links to each section, i.e., what we are looking for here is having the ability to link to lines, as you can do at GitHub, Travis etc.
Suggested by Jerome.
As it is right now, there are cases where there is no feedback telling why things failed. One example is during a timeout, then the log file just "stops" (one example can be seen here).
There should be something said at the job page about why it failed. Either we extend the status to say "Timeout" and not just "Failed" as it says today. Alternatively we could add a line at the end of the log file saying "Timeout reach (xyz seconds)
".
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.