Git Product home page Git Product logo

ibart's People

Contributors

jbech-linaro avatar

Stargazers

 avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

Forkers

vchong jforissier

ibart's Issues

Add support to run remote job definition files

In some cases it's convenient to put the job definition directly into the git tree, i.e., similar to what you can do with Travis and Shippable. Having this in IBART would probably be useful and can help GitHub project owner writing and testing their own job-definitions.

Single quotes in payload not handled correctly (possibly SQL injection attack)

The commit message in pull request OP-TEE/optee_os#2485 generates a webhook payload containing

"body": "When processing the source files for an in-tree user TA (ta/*/user_ta.mk),\r\nmake sure not to insert a double slash in the object file path.\r\n\r\nFixes the following error:\r\n\r\n $ make -s\r\n $ make clean\r\n    CLEAN   out/arm-plat-vexpress\r\n rmdir: failed to remove 'out/arm-plat-vexpress/ta/avb': No such file or directory\r\n Makefile:98: recipe for target 'clean' failed\r\n make: *** [clean] Error 1\r\n\r\nThe error results from the fact that we have two kinds of object files in\r\nthe in-tree TAs:\r\n - The object files built from ta/*/user_ta.mk. For AVB, we have\r\n   out/arm-plat-vexpress/ta/avb//entry.o (notice the repeated slash).\r\n - The object files that correspond to \"specified source files\", i.e.,\r\n   constructed from $(spec-out-dir) and $(spec-srcs). For AVB we have\r\n   out/arm-plat-vexpress/ta/avb/user_ta_header.o.\r\nWhen \"make clean\" creates the list of directories to be removed, it strips\r\nthe /filename part and keeps only the directory part, resulting in:\r\n\r\n rmdir ...  out/arm-plat-vexpress/ta/avb/ out/arm-plat-vexpress/ta/avb\r\n\r\nTrying to remove the same directory twice: \"No such file or directory\".\r\n\r\nFixes: https://github.com/OP-TEE/optee_os/issues/2484\r\nSigned-off-by: Jerome Forissier <[email protected]>\r\n\r\n<!--\r\n    If you are new to submitting pull requests to OP-TEE, then please have a\r\n    look at the list below and tick them off before submitting the pull request.\r\n\r\n    1. Read our contribution guidelines:\r\n         documentation/github.md.\r\n\r\n    2. Read the contribution section in Notice.md and pay extra attention to the\r\n       \"Developer Certificate of Origin\" part:\r\n         https://github.com/OP-TEE/optee_os/blob/master/Notice.md#contributions.\r\n\r\n    3. You should run checkpatch preferably before submitting the pull request.\r\n\r\n    4. When everything has been reviewed, you will need to squash, rebase and\r\n       add tags like `Reviewed-by`, `Acked-by`, `Tested-by` etc.\r\n\r\n    NOTE: This comment will not be shown in the pull request, so no harm keeping\r\n    it, but feel free to remove it if you like.\r\n-->\r\n",

where part of this commit message is saying:

... failed to remove 'out/arm-plat-vexpress/ta/avb': No such ...

The single quotes here terminates the SQL query here incorrectly and therefore fails to store a record.

To fix this error and prevent an eventual SQL injection attack one needs to sanitize the input.

Report back the error cause in the log file

As it is right now, there are cases where there is no feedback telling why things failed. One example is during a timeout, then the log file just "stops" (one example can be seen here).

There should be something said at the job page about why it failed. Either we extend the status to say "Timeout" and not just "Failed" as it says today. Alternatively we could add a line at the end of the log file saying "Timeout reach (xyz seconds)".

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.