Git Product home page Git Product logo

csv-writing's People

Contributors

jbclements avatar shhyou avatar

Stargazers

 avatar  avatar  avatar

Watchers

 avatar  avatar

csv-writing's Issues

csv-writing does not provides `make-csv-printing-params`

Hello! Today I found that when trying to configure display-table, csv-writing does not provides make-csv-printing-params.

Example:

(require csv-writing)
(display-table '((1 2 3) (4 5 6))
               #:printing-params (make-csv-printing-params
                                  #:quotes-only-when-needed? #f))

The fix was: in line 7 of main.rkt change:

 table-cell->string)

To:

 table-cell->string
 make-csv-printing-params)

Thanks for the library!

Newline in tsv

I think that default-tsv-printing-params (or rather, tsv-string-converter) is incorrect.

> (table-row->string '("1" "2\n3"))
"1,\"2\n3\""
> (table-row->string '("1" "2\n3") #:printing-params default-tsv-printing-params)
"1\t2\n3"

Readers would think that 3 is on a new row, which is not the case.

#:quotes-only-when-needed? doesn't seem to work

> (define (tsv-string-converter str)
    (match str
      [(regexp #px"\t")
       (error 'tsv-string-converter "no tabs allowed: ~e" str)]
      [other str]))
> (define default-tsv-printing-params2                                                                                                                                                   
    (make-csv-printing-params                                                                                                                                                             
      #:string-cell->string tsv-string-converter                                                                                                                                        
      #:quotes-only-when-needed? #f                                                                                                                                                        
      #:column-separator "\t"))
> (table-row->string '("1" "2\n3") #:printing-params default-tsv-printing-params2)
"1\t2\n3"

Improve display-table-row function

  1. It doesn't have default port set to current output as in display-table
  2. It is missing from scribble docs

Please let me know what you think and I can make a PR if you are okay with these changes

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.