Git Product home page Git Product logo

feeds-issues's People

Contributors

jaywick avatar

Watchers

 avatar

feeds-issues's Issues

Subscribe to subreddit

Reddit supports RSS and possibly we could subscribe by adding /r/news into the subscription input

Some thumbnails appear pixelated

Describe the bug
Some thumbnails in feed appear pixelated. For example most images from Gizmodo or Lifehacker

Steps To Reproduce
Steps to reproduce the behavior:

  1. Add lifehacker.com to library
  2. Go back to feed
  3. Note thumbnails are pixelated

Expected behavior
Ideally non pixelated but at least made to fit

Screenshots
Screenshot_20200412-084817

Smartphone (please complete the following information):

  • Pixel 4XL, Android 10

When network down, image assets for app are missing

Describe the bug
Images for items such as nav bar or empty states are missing when network is down

Steps To Reproduce
Steps to reproduce the behavior:

  1. Turn off network
  2. Open app

Expected behavior
Show empty state illustrations and nav bar icon

Actual behavior
Empty state illustrations and nav bar icon missing

RSS XML parsing now broken

Describe the bug
RSS XML parsing is now broken after Atom reading introduced in beta 4 (#10)

Note that atom feeds parse correctly.

Steps To Reproduce
Steps to reproduce the behavior:

  1. Go to Library tab
  2. Enter a website that has a standard RSS XML format (not Atom)

Expected behavior
Get validation error "The RSS format could not be parsed"

Actual behaviour
RSS parse error

Smartphone (please complete the following information):

  • Device: Pixel 4 XL
  • OS: Android 10
  • Version: Beta 4

Screenshot_20191226-221940

Back button does not exit the app

Describe the bug
Pressing back from the main Feed tab does not exist the app

Steps To Reproduce
Steps to reproduce the behavior:

  1. Go to the Feed tab
  2. Press the back button on your device (or back gesture)

Expected behavior
The app exits.

Screenshots
The app remains, back button does nothing.

Smartphone (please complete the following information):

  • Device: Pixel 4 XL
  • OS: Android 10
  • Browser: N/A
  • Version: v0.11.0

No way to refresh after network down empty-state

Describe the bug
There's no way to retry from the "Check your network and try again" screen

Steps To Reproduce
Steps to reproduce the behavior:

  1. Turn off your networking
  2. Open Newsfeed app
  3. See the no-network empty state
  4. Turn on networking

Expected behavior
A way to retry and get latest stories

Actual behaviour
No way to retry

Screenshots
Screenshot_20190909-054156

Support Atom feeds

Atom feeds have a different format to the current RSS parsing strategy

Sample

From https://validator.w3.org/feed/docs/atom.html#sampleFeed

<?xml version="1.0" encoding="utf-8"?>
<feed xmlns="http://www.w3.org/2005/Atom">

  <title>Example Feed</title>
  <link href="http://example.org/"/>
  <updated>2003-12-13T18:30:02Z</updated>
  <author>
    <name>John Doe</name>
  </author>
  <id>urn:uuid:60a76c80-d399-11d9-b93C-0003939e0af6</id>

  <entry>
    <title>Atom-Powered Robots Run Amok</title>
    <link href="http://example.org/2003/12/13/atom03"/>
    <id>urn:uuid:1225c695-cfb8-4ebb-aaaa-80da344efa6a</id>
    <updated>2003-12-13T18:30:02Z</updated>
    <summary>Some text.</summary>
  </entry>

</feed>

Requirements

  • parsing strategy
  • cheap validator
  • simple checker before choosing strategy

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.