jaysandhu / neovim-mac Goto Github PK

Hiya - looking forward to trying out this GUI 🙂 I thought I'd submit an issue with the build shell script.

If you don't already have cmake or any other other tools like automake or autoconf installed the neovim installer will fail on building Neovim, but unfortunately the build script just checks if the Neovim folder is there, (which it still will be if there's a failed build) so that step gets skipped and the build fails.

Opening and closing tabs plays one animation at a time, which leads to small delays affecting usability. Probably, it should be better if animations of closing/opening a tab will be played simultaneously? I've checked Chrome's animations and it seems that they're instantly selecting previous tab and playing async closing animation on the tab that's closed.

Anyway, thank you for the app, it really feels good and native to me as it's pretty minimalistic! Looking into newer versions and probably a brew package :)

The default font is one that does not properly render certain special characters like symbols. I would like to change the font to MesloLGS NF, my preferred terminal font. I don't see an option for this in the settings, and the solutions I've found online involving ginit.vim are specific to nvim-qt and fvim, which are obviously not the same program as this one.

Neovim 0.10 introduced inlay hints, so I'm excited to use the new version.
Unfortunately, the currently released version of this app only allows using the bundled 0.8.x nvim binary.

It would be nice to have a setting that allowed selecting a specific nvim binary to use as an override for the bundled version.

When I try to copy text with Command-C in Visual Block mode, I get a beep sound. It does work in Visual Character or Visual Line mode though. I think in the -copy: method, nvim.get_mode() is returning unknown instead of visual_block?

MacVim provides a bundled mvim script to launch the app from the command line. There are also symlinked variants for mview, mvimdiff, etc. That script seems to work by invoking the bundled Vim binary with the -g flag plus whatever other flags as appropriate. Since neovim works differently (no -g), I don't think that approach would work. I wonder if you have thought about this?

The active buffer's filename isn't shown in the title bar. Only "NVIM" is shown. This is the release build v0.1 (1).

Title bar should display "[No Name] - NVIM":

Title bar should display "vimrc (~/.vim) - NVIM":

Steps to reproduce:

1. Open neovim-mac window (I've used default theme and settings)
2. Press <Cmd-Shift-F> to enter fullscreen
3. Move cursor to some blank lines such as gaps between paragraphs
4. The cursor disappears on these lines and appears again when it's not in any blank line

Neovim.app renders underlines in red instead of the default SlateBlue. The screenshot shows Neovim.app in the foreground with nvim running in iTerm2 behind it.

Hi,

I thought I'd take a look at this in my quest to retire MacVim. As head allows including a pre-built binary I thought I'd try building from that rather than the v0.2 release which relies on an old patched version of Neovim.

In my first attempts the build failed (MacOS 13.5, Xcode 14.2, arm64) with three fatal errors all linked back to msgpack.hpp:

...
/Users/timhatch/Developer/neovim-mac/src/msgpack.hpp:21:10: fatal error: 
      'coroutine' file not found
#include <coroutine>
         ^~~~~~~~~~~
1 error generated.

I compared msgpack.hpp in head with the v0.2 release and can see that it now calls #include <coroutine> where v0.2 called #include <experimental/coroutine> (and likewise there are a few functions in msgpack.hpp/.cpp which used std::experimental::suspend_never|suspend_always|coroutine_handle and have now dropped the experimental)

I guess this is an issue with Xcode (and its included C++ standard library) and I was able to get the build to succeed by adding back experimental.
EDIT: I see the switch from include <experimental/coroutine> to include <coroutine> was made in the last commit to fix warnings in Xcode 14.

If I'm correct, I guess the question would be whether to include some note in the readme about the required Xcode version (I don't know how otherwise to ensure that an up-to-date version of the C++ standard library is available).

Now that I've got everything up and running I'll have a play with the app, then perhaps hold my breath and update XCode...

I'm getting a crash on launch in NVWindowController.mm:

A few lines up, if I change:

to:

it launches successfully. I'm not sure, but I think ARC is deallocating the newly allocated NVTab without the CFBridgingRetain.

When opening a file, the app continues requesting permission to access the Documents folder (and Desktop, and Downloads). Those are all iCloud folders. Every time. But I’ve explicitly given it access, and additionally, Full Disk Access in System Settings.

It doesn’t always happen when opening a file outside of those folders…although the dialogs regular pop up anyways, I’m guessing when nvim-tree, et al scans those folders.

In Insert Mode, if I have
ABC
in my buffer with the insertion point right after the C and I do command-V to paste D I get
ABDC
whereas I expected to get
ABCD

Does neovim-mac support native scrollers? If not, is this something you are planning?

Hello,

First, thank you so much for this project! I've spent many weeks testing out most of the Neovim-GUI apps and terminal emulators, and I think I've finally found my peace with Neovim-Mac. It's the fastest Neovim client in my tests and has minimal memory footprint!

I've already removed font-smoothing from my local build, by changing these lines to false on src/font.mm:

    CGContextSetAllowsFontSmoothing(context.get(), false);
    CGContextSetShouldSmoothFonts(context.get(), false);

This gives me much crisper looking fonts. Without the extra boldening, I also get some extra spacing between the lines.

I would still like to increase the line-spacing, just a little bit more.

Is there a simple way where I could hardcode this somewhere in the source code and rebuild Neovim-Mac with it?

I tried to find something that would resemble this setting in the sources but no success so far. (I don't know the languages used for Neovim-Mac)

Thanks!

as title described, command in /usr/local/bin could not load. when:echo $PATH only shows:/usr/bin:/bin:/usr/sbin:/sbin

On my system (2020 MacBook Pro, M1 Pro processor) starting the application results in a black screen where using any menu command does nothing in the window.
I'll try building it from source with Xcode and see if that fixes anything.

For container/VM based development workflows, it would be useful to be able to use this as a front-end for a remote neovim client.

This can be accomplished through the regular nvim binary using the remote options.

Prior art for implementing this as a nvim library consumer can also be found in Neovide

I imagine that this is probably a bug in something you can't control, but here it is anyway.

/Library/Developer/CommandLineTools/usr/bin/cc -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX10.15.sdk -g -O2 -fomit-frame-pointer -Wall  -fPIC -DLUA_USE_APICHECK -DLUA_USE_ASSERT -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -U_FORTIFY_SOURCE  -DLUA_ROOT=\"/Users/john/projects/neovim-mac/build/neovim/.deps/usr\" -DLUA_MULTILIB=\"lib\" -fno-stack-protector   -c -o lj_opt_mem.o lj_opt_mem.c
BUILDVM   lj_folddef.h
host/buildvm -m folddef -o lj_folddef.h lj_opt_fold.c
make[2]: *** [lj_folddef.h] Segmentation fault: 11
make[2]: *** Deleting file `lj_folddef.h'
make[1]: *** [src/luajit] Error 2
ninja: build stopped: subcommand failed.
make: *** [deps] Error 1


❯ xcode-select --version
xcode-select version 2384.
❯ sw_vers
ProductName:    macOS
ProductVersion: 11.2.2
BuildVersion:   20D80