jayhill90 / wordpress-pma Goto Github PK

Currently with utilizing shouldComponentUpdate() we're getting a console warning about onClick expecting a function. This is working for navigation but it is refreshing the entire page making extraneous requests.

Currently when using /ableton as the route path, this path is being passed into SinglePage as undefined, we're getting two console logs for undefined on some attributes and in the GET request.

Screenshot can be found here

When using /:slug in the Route it seems to actually almost work but does return undefined for the slug path in the URL on the get request like above screenshot. I think the issue with the route for home showing up was due to matching maybe? Not fully sure on that one need to explore it more.

Here's the props from the React Chrome extension for the route.

{
  "match": {
    "path": "/:slug",
    "url": "/ableton",
    "isExact": true,
    "params": {}
  },
  "location": {
    "pathname": "/ableton",
    "search": "",
    "hash": "",
    "key": "p5kd2z"
  },
  "history": {
    "length": 50,
    "action": "PUSH",
    "location": {},
    "createHref": {},
    "push": {},
    "replace": {},
    "go": {},
    "goBack": {},
    "goForward": {},
    "block": {},
    "listen": {}
  }
}

Looks like params is showing as empty, and based on the react router documentation example here then params should have something. I get errors when I try to use the this.params.slug call in SinglePage's url call.

Currently we are able to go from the Homepage to a Page and everything renders as expected, however we are having trouble going from Page to Page. Will need to look into.