javiereguiluz / easyslugger Goto Github PK

I'm reviewing the code and i can see some things that can be improved:

• The logic of uniqueSlugify is repeated in all the sluggers, must be good to implement that logic in a AbstractSlugger.
• Create a DEFAULT_SEPARATOR in the SluggerInterface and use it.
• Remove the static keyword from the slugify and uniqueSlugify methods in favor of a SluggerFactory

This repo is supporting Chinese, not Japanese.
The slug for "日本語" in Japanese must be "ni-hon-go", not "ri-ben-yu". So, please change all fixtures's filename: expected and input, and in README.
Thanks.