Add yahoo Finances as Exchange Rate implementation about javamoney-lib HOT 18 CLOSED

Sounds good, this explains the YQL for Finance (and other sources on the bottom) http://stackoverflow.com/questions/10040954/alternative-to-google-finance-api

from javamoney-lib.

https://github.com/kosik/jsr354-ri catch one eye here

from javamoney-lib.

Thanks, but it should not go to RI;-(

from javamoney-lib.

Sorry for the possible confusion (e.g. the Moneta module @otaviojava cloned here likely will be a module, but to have default providers IMF and ECB should stay as modules under Moneta;-)
We may manually transfer the suggested file changes from your pull-request, or you could place it here instead under "exchange-rate", I can later create a module once I am at my own box.

from javamoney-lib.

The second attempt pushed into javamoney-lib.

To be honest i implement it for my local project necessity. It went out that it will be much faster, easer and safer to implement the Parser than use a third-party service or invent something by myself. So, thank you guys for the work :) I have not done any Test Development Cases. I just did some smoke tests and it was enough for me.

By the way, according to one of Stackoverflow posts YAHOO does not provide official support of exchange rate currencies. It seems like the currencies are available only as a part of Yahoo Finances but not like the independent web-service.

from javamoney-lib.

Ok.
I can continue your code and the tests.
I will use your code as first step, thank you.

from javamoney-lib.

Which code, the one from the RI PR? As long as it's not merged there (here no problem, as this is not subject to EG/JCP membership ;-) fine. I just created a structure of a sub-module https://github.com/JavaMoney/javamoney-lib/tree/master/exchange-rate/exchange-rate-yho

from javamoney-lib.

I will create the structure on lib

from javamoney-lib.

The folder is there, but happy if you fill it (both of you unless you prefer to manually carry over the proposed PR, please don't use javamoney.moneta package name. Either "org.javamoney.lib.exchange" or (since a few other modules like "calc" also did) "org.javamoney.exchange" with sub-packages like the "yhoo" or "yahoo".

from javamoney-lib.

I did the first step on yahoo implementation and I did some tests.
Is there any way to find out from date?

from javamoney-lib.

Please as a next step fix the package name, a library here must not be "org.javamoney.moneta.internal.convert.yahoo". See above, "org.javamoney.lib.exchange.yahoo" ("convert" was also OK, but you picked the module name so better use "exchange" in this context only;-) or "org.javamoney.exchange.yahoo" but not "moneta" or any other pre-defined existing package namespaces.

from javamoney-lib.

@otaviojava As of now all tests accessing real yahoo/frc rates do actually fail. Can you have a look at it, please?

from javamoney-lib.

Do the APIs still exist at Yahoo? ;-)

from javamoney-lib.

@atsticks yes, I can do it

from javamoney-lib.

Please do. @atsticks By when would you envision Library 0.9 (would not call it 1.0 yet, maybe based on the next RI updates ;-) ) to be released or is there a downstream dependent waiting for it?

from javamoney-lib.

from javamoney-lib.

If there is no requirement on the signature to sign those (like for the JSR earlier), I can publish them to Bintray.

from javamoney-lib.

Fixed impl.

from javamoney-lib.