Git Product home page Git Product logo

Comments (7)

otaviojava avatar otaviojava commented on June 17, 2024

@keilw I am just waiting the discussion about the modularization on RI. If will go or not go. To discuss the best strategy to put the exchange rate providers, if they stay on RI project or we can create a project to put all exchange rate provider and add, just these two, as dependency.

from javamoney-lib.

keilw avatar keilw commented on June 17, 2024

Your picture got it right, and even in a "Jigsaw" world where IMF and ECB provider might be optional or user-defined, having them as modules underneath RI makes perfect sense. Others "out in the wild" are subject to extensions. It just does not work to have RI "pull in" something by default, it must be part of RI. @atsticks was pretty clear about that in the discussion thread. If there's no input (@jodastephen was just defending his questionable and outdated JDK 1 era design decisions in java.time, before he decided to leave the mailing list;-) other than what we got it is up to the Maintenance Lead to decide what's best for the RI.

from javamoney-lib.

keilw avatar keilw commented on June 17, 2024

Just see @atsticks's mail a little while ago. I think he answered the questions for the "default" providers.

from javamoney-lib.

keilw avatar keilw commented on June 17, 2024

@otaviojava Unfortunately you created some toxic mix-up between "convert" and "function". Not only tests but some convenience Lambda stuff now makes modularizing harde;-(

from javamoney-lib.

otaviojava avatar otaviojava commented on June 17, 2024

No.
I am using just interface on the test.
Just create an implementation to test.
I take care this:
But look to this class:
ExchangeRateProviderMock

from javamoney-lib.

keilw avatar keilw commented on June 17, 2024

It was in "function", is it now in the new "convert" module?

from javamoney-lib.

otaviojava avatar otaviojava commented on June 17, 2024

These functions sum, average using the rate to convert, etc. using the Exchange Rate Provider, but they remain one function. I believe it's the best place for them.

from javamoney-lib.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.