Comments (7)
@keilw I am just waiting the discussion about the modularization on RI. If will go or not go. To discuss the best strategy to put the exchange rate providers, if they stay on RI project or we can create a project to put all exchange rate provider and add, just these two, as dependency.
from javamoney-lib.
Your picture got it right, and even in a "Jigsaw" world where IMF and ECB provider might be optional or user-defined, having them as modules underneath RI makes perfect sense. Others "out in the wild" are subject to extensions. It just does not work to have RI "pull in" something by default, it must be part of RI. @atsticks was pretty clear about that in the discussion thread. If there's no input (@jodastephen was just defending his questionable and outdated JDK 1 era design decisions in java.time, before he decided to leave the mailing list;-) other than what we got it is up to the Maintenance Lead to decide what's best for the RI.
from javamoney-lib.
Just see @atsticks's mail a little while ago. I think he answered the questions for the "default" providers.
from javamoney-lib.
@otaviojava Unfortunately you created some toxic mix-up between "convert" and "function". Not only tests but some convenience Lambda stuff now makes modularizing harde;-(
from javamoney-lib.
No.
I am using just interface on the test.
Just create an implementation to test.
I take care this:
But look to this class:
ExchangeRateProviderMock
from javamoney-lib.
It was in "function", is it now in the new "convert" module?
from javamoney-lib.
These functions sum, average using the rate to convert, etc. using the Exchange Rate Provider, but they remain one function. I believe it's the best place for them.
from javamoney-lib.
Related Issues (20)
- Add Google Finances as Exchange Rate implementation HOT 2
- Could we split "update_exchange" script and move it to each module?
- Move javamoney-cdi to Midas? HOT 11
- Remove "bundles"
- Test Bootstrap
- Support HTML5 Microformats? HOT 1
- Tests fail in FCR provider module (exchange) HOT 2
- Prepare release of library module HOT 4
- Should every module be an OSGi bundle? HOT 1
- Update readme
- Update license headers HOT 2
- Consider an Exchange module for Bulgarian Lev
- Exchange Rate Providers for Google Currency
- Move "retired" to javamoney-shelter
- Fix Readme HOT 3
- Unable to build due to moneta.core 1.2 jar is missing HOT 5
- `CompoundInterest.apply` ignores `timesCompounded` and uses 1
- YieldToMaturity calculation fault
- Replace Bintray from JavaMoney-Lib
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from javamoney-lib.