jatufin / multicave Goto Github PK

I tested your application on two different occations (Monday and Tuesday) and got to witness two different versions of the project. Quite a lot happened in just one day! At the time of writing this the following features could be tested:

• Creating a user account
• Logging into the application
• Posting messages
• Testing our the test-dungeon
• Creating your own dungeon

As a tester using the following features were easy to use: creating an account, logging in, posting messages, trying out the test dungeon. However the functionality to create your own dungeon was at this stage still hard to follow. It was hard to understand how the dungeon/cave would be structured and how the conditions worked. When I tried to test my dungeon, I got a notification that it was not found, so I couldn't test my adventure. Maybe these features were still a work in progress?

I tested the app with Chrome and with text-based browser Lynx. With Lynx I frequently got warnings that documents were to be reloaded and all information in forms would be lost. I assume this might be an issue with cookies and redirects (not sure)? As a user those warnings were concerning since the app involves filling out a lot of forms. Would what I wrote be stored or lost? Even though this course is about creating a db-application I've understood that it is good to make the front polished. This still requires more work at this stage.

To best of my knowledge there was no way of creating an admin account, so I could not test the admin features. The banned words - feature sounds very interesting, would've loved to test that out!

The code was nicely divided into modules and was very easy to read. Well done! I also learned new things from looking through your code. For instance your session 'items', logout process and error handling contained ideas I hadn't thought of.

All in all I very much like the idea behind this application and the execution so far has some very interesting ideas, would love to test a finished application in the future! At this time I am concerned about the state of the project and the time frame available. Deadline is in two weeks and there is a lot to be done. The instructions were to have an application requiring only the final touch-ups at this time, and I don't think that this project is quite there yet. I'd imagine finishing this project in time would require quite a lot of hours. I wish you all the best for the end-crunch!

Annan palautteen suomeksi vaikka olet käyttänyt dokumentaatiossa englantia, toivottavasti tämä on ok.

Dokumentaatio on kattava ja selkeä, siitä saa hyvän kuvan sovelluksen tarkoituksesta ja rakenteesta.
80- ja 90-luvuilla paljon tietokoneiden kanssa leikkineenä tekstiseikkailut tuli tutuiksi ja ideasi on mielestäni mainio.

Auki jää ehkä kysymys siitä, että "onko tarinalla loppua", eli palataanko aina jotenkin alkuun / johonkin kohtaa tarinaa
vai tuleeko esimerkiksi tilanne, jossa ei enää pysty etenemään. Tällä hetkellä voi lisätä huoneen, jossa ei ole yhtään
vaihtoehtoa valittavana, onko se tarkoitus?

Koodi on selkeää ja helppolukuista, tosin sovellus ei vielä ole kovin laaja. Laajetessaan koodi kannattanee jakaa
useampiin moduuleihin. Myös tietokannan taulu dungeons on melko suuri. Voisiko olla muokattavuuden kannalta
jatkossa helpompaa, jos sen jakaisi (esim. erottaisi erikseen dungeons <- choises <- targets)?

Näihinkin kannattaa varautua:

• käyttäjätunnuksen / salasanan validointi (nyt kentät voi jättää tyhjäksi, tosin tyhjällä tunnuksella ei pysty kirjautumaan)
• huone ilman tägiä
• huoneelle annetaan tägi, joka on jo olemassa.

Alku näyttää kyllä hyvältä ja niinkuin sanoin, idea on mielestäni hyvä. Tsemppiä jatkoon!