Git Product home page Git Product logo

amp-ads-testing's People

Contributors

craigsaunders avatar jasti avatar megankj avatar noodlesnz avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

amp-ads-testing's Issues

Error: 3p iframe url disabled for adsense​​​

When i use remote.html on https subdomains (of the same amp domain)
and i load an amp-ad="adsense" I receive this error:

3p iframe url disabled for adsense​​​

It's ok or I violate AdSense rules or I can't use AdSense with remote.html?

(I use amp-ad="adsense" for AdX ad unit)

Thank's
Lorenzo

Example of AMP-Ad component using DFP and Third party AMP-Ad Extensions

Hi

Looking at the DFP / 3rd Party Ad-Server Examples - here - https://dfp-amp-testing-1185.appspot.com/ - I can't see an example that uses Rubicon's fastlane adaptor and wanted to know if its possible to combine multiple adaptors/vendors via DFP.

Example: I want my AMP pages to call DFP and utilise Rubicon fastlane and Criteo's RTA AMP-AD extensions:

https://github.com/ampproject/amphtml/blob/master/ads/rubicon.md
https://github.com/ampproject/amphtml/blob/master/ads/criteo.md

Is it possible to use both with DFP - essentially I want to be able to utilise both adaptors so targeting information is returned as part of the DFP ad-request made on AMP pages ?

Is this possible ?

Thanks in advance,
Rupesh

Video Companion Ads

Hi, I can't find any documentation about the companion ads for Videos.

Is it possible to set this up in AMP?

Is there any example?

Currently on our non AMP site we have the "enableVideoAds" dfp config, along the ".addService(googletag.companionAds())" for each of the other slots on the page.

Any help is appreciated, thank you.

Google CDN validator accepts invalid unicode data attributes.

If a code snippet gets pasted from a pdf the '-' characters in say <amp-ad data-ix-id= ... get mangled to unicode e2 80 90. If this makes it to a production web site the Google AMP CDN will accept the invalid attribute (the Cloudflare CDN and JS validator will correctly reject it).

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.