jasonnutter / vscode-codeowners Goto Github PK

As seen above, it seems that there is a blank space for an additional user here

Hello, first of all thanks for your VSCode extension!

I'm finding the following error everytime I try to get the owner of the open file:

TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received type object
	at assertPath (path.js:39:11)
	at Object.normalize (path.js:287:5)
	at trueCasePathSync 

Did you notice the same error? Do you want other infos?

Type: Bug

Loading VS code with this extension

Extension version: 1.1.1
VS Code version: Code 1.83.1 (Universal) (f1b07bd25dfad64b0167beb15359ae573aecd2cc, 2023-10-10T23:46:55.789Z)
OS version: Darwin arm64 22.6.0
Modes:

vsliv368cf:30146710
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
vserr242:30382549
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
vscoreces:30445986
vscod805:30301674
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593cf:30376535
pythonvs932:30410667
py29gd2263:30856252
vscaac:30438847
vsclangdc:30486549
c4g48928:30535728
dsvsc012cf:30540253
pynewext54:30695312
azure-dev_surveyone:30548225
3biah626:30602489
89544117:30613380
2i9eh265:30646982
showlangstatbar:30737416
a2ce3375:30757347
7ij38806:30736111
pythonfmttext:30731395
fixshowwlkth:30771522
showindicator:30805244
pythongtdpath:30769146
i26e3531:30792625
pythonnosmt12:30797651
pythonidxpt:30866567
pythonnoceb:30805159
dsvsc013:30795093
dsvsc014:30804076
dsvsc015:30845448
pythontestfixtcf:30871695
pythonregdiag2:30871582
pyreplss1:30865275
pythoncet0:30874138
pythontbext0:30864172

I have a monorepo where the root workspace has a .github/CODEOWNERS file, but I also have a folder in my workspace which is a subdir of the root workspace. When I open a file in the subdir, it doesn't find the CODEOWNERS file. I assume this is because it doesn't recursively walk up to find a .github folder.

Our CODEOWNERS file has entries like:

src/foo/bar/                @"Bar Tender"
src/foo/baz/                @"Nuther Guy"

Despite the quotes, these names are being split apart, and they show up as multiple (2) owners. See these screenshots:

It would be "A Mazing" if you could honor quoted strings as a single name. Thanks in advance!

My company has a lot of CODEOWNERS files that just look like this:

/ @ckovatch

i.e. "everything in this repo is owned by ckovatch"

This doesn't seem to work with the plugin, it shows "CODEOWNERS: None" everywhere.

I see a similar issue here #4 but maybe it only addressed paths prefixed with / and not literally the path /?

Thanks for the plugin, really useful. One small addition that would be helpful is the ability to click on the relative paths and perhaps highlight the folder on the explorer, or something similar.

Thanks again!

The codeowners npm package had a problem when the CODEOWNERS file didn't use \n as linebreak character. In the case of Windows (\r\n) this resulted in an additional, empty username entry for code owners.

I made a PR for the library which just got released in version 4.2.1. It would be great if you could make a new release of your extension available for the marketplace, so it properly works on Windows.

Hey, it's pretty common to have the CODEOWNERS file located in <rootFolder>/.github or <rootFolder>/.gitlab.
It should be straightforward to implement this, I might try it this week, but at least we have an issue to refer to.

When we open a staged file and that it shows the comparison file tab (with (Index) in the tab name), the CODEOWNERS are shown as "None".