Git Product home page Git Product logo

endpoint's People

Contributors

jarmourato avatar

Watchers

 avatar  avatar

endpoint's Issues

Replace obscure Any โ†’ String conversion with `LosslessStringConvertible` protocol

Ref.:

components.queryItems = parameters.map { URLQueryItem(name: $0.key, value: "\($0.value)") }

There's a very implicit conversion going on here, from Any to String because URLQueryItem takes in a String? as its value, yet Endpoint's Parameters is a typealias to [String:Any].

I suggest to change the Parameters to [String:LosslessStringConvertible], this way it transparently accepts anything that can be transformed to Strings losslessly, e.g. Ints, Doubles, Strings, enums with raw values, or even custom objects if the user decide to implement its conformance to LosslessStringConvertible. This would be a huge type-safety improvement imo ๐Ÿ‘

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.