Comments (4)
The initial thinking was that handleChangeValue would mostly be used with custom inputs which donβt always expose legit onBlur. However I now agree that that is asymmetric.
Instead there should be a handleBlurValue and handleChangeValue should accept an optional 3rd argument to blur.
Which brings me to my next point which is that handleChangeValue/handleBlurValue should probably be named differently as they are not really event handlers, they should be like setFieldValue and setFieldTouched
from formik.
Yeah I think you're right. What if we broke out to:
setValue(field, value)
- sets the field value but does not set touched state
touchValue(field, value)
- sets and touches the field value
touchField(field)
- touches the field
from formik.
touched
doesn't have a singular in english that makes any sense.
What about this API?
// values
handleChange: (e) => void
setFieldValue: (field: string, value: any, touch?: boolean) => void
setValues: (values: V) => void
// errors
setFieldError: (field: string, msg: string) => void
setErrors: (errorsObject: FormikError) => void
// touched
handleBlur: (e) => void
setFieldTouched: (field: string, value: boolean) => void
setTouched: (touchedObject: FormikTouched) => void
// error
setError: (e: any) => void
from formik.
I think the above API looks good and consistent to me.
The one I'm still a little uncertain about is the optional touch?
parameter on setFieldValue
. It means the component is implementing a callback signature that seems slightly idiosyncratic and specific to Formik, reducing reusability of the component in non-Formik forms.
But it feels appropriate to give the component control over when and whether to perform a touch, rather than leaving that up to the user of the component, so I think it's probably worth the tradeoff.
from formik.
Related Issues (20)
- How to uncheck already checked checkbox? HOT 1
- Unhandle error on handleSubmit function HOT 1
- Validation Error HOT 4
- handleChange can't target state values with delimiters
- Add correct types for `Field` HOT 6
- onPaste + setFieldValue does not work as intended HOT 2
- Get validating state of individual components
- Page reloads on submit if form is inside drawer component HOT 5
- Margin not added in UI HOT 3
- Uncaught (in promise) TypeError: e2 is null [CoreValidator.ts:138:2]
- Why do I have to specify a name again when using useField's onChange function?
- Support for React Native's SyntheticEvent type
- formik file upload handling HOT 4
- Consider shipping a LICENSE file with your npm package HOT 1
- useField's onChange function should accept non-string values as args
- Formik.dirty is not reacting to nested changes HOT 1
- Docs layout is a bit broken HOT 4
- React Native form resets to initial values
- Terneries, espescially deeply nested ternaries, make code difficult to read. Please do not do this. HOT 1
- RangeError: Maximum call stack size exceeded HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from formik.