jarch09 / ts-png-to-ico Goto Github PK

I've not checked when this becomes necessary, but what I noticed is that I have to import your library like this:

import pngToIco from 'ts-png-to-ico';
const { generateIco } = pngToIco;

Potentially relevant parts of tsconfig.json:

"target": "es2017",
"lib": ["es2017"],
"module": "node16", 
"moduleResolution": "node16", 
"esModuleInterop": true, 

May be worth mentioning in the documentation.

First off thank you for writing this, was about to write something myself and did a check and found that you had already created this!
I did notice that there's a dependency missing: tslib
In my dev-environment that was not required to specify explicitly, but once deployed it can be, so an easy one to miss. Just thought I'd let you know.

When updating your package I realized I had one more bug to report:

"main": "dist/index.ts",

causes:

  throw new ERR_MODULE_NOT_FOUND(
        ^
CustomError: Cannot find package './node_modules/ts-png-to-ico/' imported from ./src/routes/integration/index.ts

changing it to:

"main": "dist/index.js",

solves it for me, but not sure this is the best solution.