japaric / hash32 Goto Github PK

View Code? Open in Web Editor NEW

9.0 3.0 9.0 47 KB

32-bit hashing machinery

License: Apache License 2.0

Rust 100.00%

hash32's Introduction

`hash32`

32-bit hashing machinery

Documentation

License

Licensed under either of

Apache License, Version 2.0 (LICENSE-APACHE or http://www.apache.org/licenses/LICENSE-2.0)
MIT license (LICENSE-MIT or http://opensource.org/licenses/MIT)

at your option.

Contribution

Unless you explicitly state otherwise, any contribution intentionally submitted for inclusion in the work by you, as defined in the Apache-2.0 license, shall be dual licensed as above, without any additional terms or conditions.

hash32's People

Contributors

Stargazers

Watchers

Forkers

xosplicer mabezdev ethindp dirbaio liamolucko addisoncrump icodein ayush1325 michel-slm

hash32's Issues

Add support for tuples

It seems that tuples containing only types that implement hash32::Hash don't implement Hash themselves:

the trait bound `(u16, u16): hash32::Hash` is not satisfied
  --> examples/dw1000_rx_tx.rs:41:27
   |
41 |     let mut known_nodes = FnvIndexSet::<_, heapless::consts::U64>::new();
   |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `hash32::Hash` is not implemented for `(u16, u16)`
   |
   = note: required by `<heapless::indexset::IndexSet<T, N, hash32::BuildHasherDefault<S>>>::new`

It would be very useful to have this.

Extend `core::hash` instead of replacing it

It's possible to implement hash32::Hasher as an extension of core::hash::Hasher, rather than a replacement:

pub trait Hasher: core::hash::Hasher {
    // This isn't the best name, but calling it `finish` would conflict with the method of `core::hash::Hasher`.
    fn finish32(&self) -> u32;
}

This would allow using the standard Hash type instead of needing a custom version, and also remove the need for a custom derive macro.

Obviously, this would be a breaking change. Even if everything else was kept the same, and a blanket impl of core::hash::Hasher for hash32::Hasher was used instead of modifying hash32::Hasher, that would break any crates which already implemented both.

I've made a draft implementation at https://github.com/Liamolucko/hash32/tree/use-std.

Add support for enums

I'm getting the following error when trying to derive Hash32 for an enum:

error: proc-macro derive panicked
   --> src/mac.rs:464:40
    |
464 | #[derive(Clone, Copy, Debug, Eq, Hash, Hash32, PartialEq)]
    |                                        ^^^^^^
    |
    = help: message: #[derive(Hash)] doesn't currently support `enum` and `union`

It would be very useful to have support for enums!

"can't find crate for `hash32`"

When depending on the hash32 create, but not the hash crate, I'm getting the following error when trying to derive Hash32:

error[E0463]: can't find crate for `hash32`                                                              
   --> src/mac.rs:299:40                                                                                 
    |                                                                                                    
299 | #[derive(Clone, Copy, Debug, Eq, Hash, Hash32, PartialEq)]                                         
    |                                        ^^^^^^ can't find crate

If I also add a dependency on hash32, the error goes away and everything works as expected.

japaric / hash32 Goto Github PK

hash32's Introduction

`hash32`

Documentation

License

Contribution

hash32's People

Contributors

Stargazers

Watchers

Forkers

hash32's Issues

Add support for tuples

Extend `core::hash` instead of replacing it

Add support for enums

"can't find crate for `hash32`"

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent