jannisx11 / wintersky Goto Github PK

Problem

bridge. has a split-screen mode that allows previewing two particle effects simultaneously. Currently, Wintersky doesn't support rendering emitters to two different ThreeJS scenes because the important Wintersky.space variable can only be set globally.
I tried switching the space variable out before starting the emitter but the Emitter.tick() function calls Emitter.start() internally so this breaks in loop mode too.

Proposed Solution

There are two possible ways I could see this being solved:

1. Turn Wintersky into a class so users can create a new instance of the class containing all relevant state

import { Wintersky, Emitter } from "wintersky"

const wintersky = new Wintersky({ space: myEmitterSpace })
// Creating an emitter...
const emitter = new Emitter(wintersky, config, options)

2. Allow passing a space property when creating a new Emitter

new Wintersky.Emitter(config, { space: myEmitterSpace })

Additional Notes

I can implement the solution you prefer if you see this as a suitable addition to Wintersky.