jannisfink / yarf Goto Github PK

It should be possible to fall through the routing function, if there is no handler. So the router can replace an existing one piece b piece.

This is very annoying (though they are there for a reason). First ideas:

• remove all the functions for responding to the requests form the superclass, so the programmer has to know which function they have to use. This would make sure that no warnings are logged, but the IDE support for auto completion does not work so well.
• ignore the warnings (I don't like this)
• suppress them (see above)

To prevent the pagemap from becoming too large, it should be possible to chain pagemaps

https://github.com/jannisfink/yarf/blob/master/src/request/PageMapper.php#L86

There is the potential of a bug. I'm kind of confused with this line, I have no clear clue, what the count($uriParts) === 1 should do...