janitortechnology / c9.ide.janitorconfig Goto Github PK

I think it would be valuable to support these following locations:

• ./janitor.json (directly inside the Cloud9 workspace, so that projects can commit their own janitor.json file in their repositories)
• ~/janitor.json (fallback)

And also the following alternative spellings for the file name:

• janitor.json
• .janitor.json

@nt1m What do you think?

Instead of having to write:

{
  "scripts": {
    "node app": {
      "cmd": "node app"
    },
    "npm run watch": {
      "cmd": "npm run watch"
    },
    "npm run lint": {
      "cmd": "npm run lint"
    },
    "npm test": {
      "cmd": "npm test"
    },
    "Send to code review": {
      "cmd": "hub pull-request"
    }
  }
}

It would be nice to be able to simplify this as:

{
  "scripts": {
    "node app": "node app",
    "npm run watch": "npm run watch",
    "npm run lint": "npm run lint",
    "npm test": "npm test",
    "Send to code review": "hub pull-request"
  }
}

When I spawn a Janitor container on https://janitor.technology I see that the c9.ide.janitorconfig plugin is loaded, and it says it has loaded all janitor.json scripts, but the Run button still has no run configurations associated to it:

Original issue: JanitorTechnology/janitor#138

See also JanitorTechnology/dockerfiles#155 (comment)

Stolen from: JanitorTechnology/dockerfiles#32 (comment)

We should also add the following user configurations to our Cloud9 workspace type:

• Code editor font-size: 14 (instead of 12)
• Default indentation to 2 spaces (instead of 4 spaces)
• Strip trailing spaces on save by default
• Maybe move the 80-chars visual indicator to the 100-chars mark?

• remove nonofficial run configurations that don't work (e.g. "Run this file")
• hack the "Run" (or "Run Project") button so that it has a better name and becomes a drop-down (instead of running whatever was last or whatever it feels like running for the current file)
• for a workflow item like "Build": "./mach build", repeat the command between brackets in the Run Configuration name like so: Build (./mach build) (to be more explicit, and avoid doing that repetition by hand in janitor.json) (EDIT: Done in #8)

When loading a Cloud9 IDE window for a Janitor project, very often the console says that the plugin managed to load its janitor.json file successfully, but the Run button has no run configurations.

Refreshing the IDE sometimes fixes this issue. @nt1m were you able to get a review of the Run config loading mechanism from the Cloud9 SDK community?

• For some ports like 8088, we need to open a specific path (not just / or /index.html) like for example /vnc.html (or /ide.html for 8089). I believe we could fix this by supporting a path attribute in our port specification:

"ports": {
  "8088": {
    "label": "VNC",
    "proxy": "https",
    "preview": true,
    "path": "/vnc.html"
  }
}

(Or maybe we could somehow merge preview and path, e.g. "preview": "/vnc.html"?)

• Additionally, some Run configurations have an attribute like "openPort": "8088":

{
  "Run (dev)": {
    "cmd": "./mach run --dev",
    "openPort": "8088"
  }
}

This attribute doesn't do anything yet, but maybe we could script Cloud9 to open the right preview when this Run configuration is triggered?

[c9.ide.janitorconfig] Failed to parse or load janitor.json
ReferenceError: script is not defined
Stack trace:
loadSettings@https://pianosa.janitor.technology/static/standalone/config/workspace-janitor.js:1542:21