Git Product home page Git Product logo

hyf-javascript3's People

Contributors

jamsrahimi avatar

Watchers

 avatar

hyf-javascript3's Issues

Elmira's feedback

Dear Jamshid, I think you can define an array for rating , then for avarageRating you van get average. and an other thing that maybe you want to use, the relation between dateOfBirth and Age below is here:
let now = new Date();
let age = now.getFullYear() - this.dateOfBirth;
return age;
good luck ;)

Feedback Homework JS3 Week 1

Hi Jams, here is my revised feedback on your homework.

  1. Your are still using the birth year in place of birth date. You could use a birth date like this:

    const firstActor = new StaffMember('Keanu Reeves', 'star', '2-9-1964');

    then in the StaffMember constructor:

    this.dateOfBirth = new Date(dateOfBirth);

    and in the getAge() method:

    let age = now.getFullYear() - this.dateOfBirth.getFullYear();

    This only gives an age without taking into account the actual birth month and day. An accurate age is more complicated to compute.

  2. A individual rating on IMDB is actually a whole number (the number of stars that you click when reviewing a movie). The rating shown on IMDB is the average of these individual ratings.

The rest of the code seems to be in working order now.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.