jamessanford / assetto-corsa-deltabar Goto Github PK

repackage DeltaBar so that Content Manager can one-click install the application

I was clicking through the various modes (best sector, optimal, ...) repeatedly and it crashed.

Looks like statusbox/format_time() expects milliseconds to only ever be an integer... There are likely more bugs in statusbox.

Exception: Thu Sep 24 05:24:46 2015
Traceback (most recent call last):
  File "apps/python/deltabar\deltabar.py", line 59, in acUpdate
    deltabar_app.acUpdate(delta_t)
  File "apps/python/deltabar\deltabar_lib\deltabar_lib.py", line 356, in acUpdate
    pos, self.lap.invalid_sectors[current_sector])
  File "apps/python/deltabar\deltabar_lib\statusbox.py", line 221, in update_frame
    self.data.textbox.set('i{}_2'.format(current_sector), format_time(current_sector_time - benchmark_sector_time, invalid=invalid, delta=True))
  File "apps/python/deltabar\deltabar_lib\statusbox.py", line 71, in format_time
    return "{}{}{}.{:03d}".format(star, sign, sec, thou)
ValueError: Unknown format code 'd' for object of type 'float'

After qualifying, the car resets position to begin the race.

The first race lap was showing the old delta data from qualifying (+0.74) throughout the entire first lap. After crossing the finish line to begin the next race lap, the correct deltas were displayed for the remainder of the race.

In this case the car was on track when qualifying ended, approx 70% around the track, having finished ~2 qualifying laps, and the car had the first starting position at Vallelunga.

Here's a skeleton config_defaults.ini that renders OK in Content Manager.

This would allow people to configure deltabar from Settings -> Apps -> DeltaBar

[Mode]
MODE=0; Display mode; 0 for vs all-time best lap, 1 for vs all-time best sectors, 2 for vs all-time optimal lap, 3 for vs session best lap, 4 for vs session best sectors, 5 for vs session optimal lap

[DeltaBar]
THEME=IRACING; Color scheme; IRACING for iRacing, SPEEDSPB for SpeedSpb Alternate, COLORDEFICIENCY for Color vision deficiency
BAR_WIDTH=800; Width
BAR_HEIGHT=60; Height
BAR_FONT_SIZE=24; Font size
BAR_DURATION=2000 ; Duration; from 200 ms to 5000 ms
BAR_MOVES=1 ; Time offset moves with bar; 1 or 0

[Background]
BAR_BACKGROUND=1 ; Draw bar background; 1 or 0
BAR_OPACITY=0.65; Background opacity; from 0.0 to 1.0
BACKGROUND_COLOR=#303030; Background color RRGGBB hex

[DetailWindow]
STATUSBOX_ENABLE=1 ; Enable window; 1 or 0
STATUSBOX_BETA=1; Include BETA text; 1 or 0

[Reset]
#To reset saved laptimes, delete the files from:
#  XXX\plugins\deltabar\xxx
RESET_DIRECTORY=...\\Documents\Assetto Corsa\plugins\deltabar\laps ; To reset laptimes, remove cars or the entire track from the cfg\Assetto Corsa\plugins\deltabar\laptimes directory; directory

For example, the Nordshleife AI spline starts at something like 0.80, and becomes 0.00 after you've been driving a minute. The current code ties the lap start and the AI spline too closely, and also assumes the AI spline position will only increase as we drive around the track.

Here's a comment from commit d03edbe :

I think the Nordschleife doesn't work very well with DeltaBar because the AI spline doesn't "start" at the beginning of the track.

Needs some bug fixing, like "when the lap timer starts incrementing, use the current location as the start, and allow it to wrap around zero", so that a recorded Nordschleife lap can look something like "0.80", "... 0.99", "1.00", "1.10", ... "1.70", "1.79"

On some tracks, the deltabar does not display any data at all.

Turns out the app does not know where the car is on the track. It uses NormalizedSplinePosition to get an approximate position, but some addon/custom tracks do not have this spline.

This could be worked around by using the 3D position of the car, not sure if it's worth the effort?

Is there any way to make the delta bar bigger by scaling it to a larger percentage?