Comments (4)
jamesgeorge007
commented on June 11, 2024
@tuunit, appreciate your thoughts and suggestions.
from github-activity-readme.
tuunit
commented on June 11, 2024
@jamesgeorge007 the first approach might not work. As far as I know github actions are not allowed to commit changes to a fork of another user. Therefore extending the CI workflow or adding another workflow that gets triggered after a merge from to generate the distribution files and commit them directly to the master branch seems like the proper solution to me.
from github-activity-readme.
jamesgeorge007
commented on June 11, 2024
I prefer generating the dist files straightaway in the PR and avoiding any follow-up commits to the default branch. If the PR author grants write access to the maintainer, won't that suffice for the GH Action 🤔
from github-activity-readme.
tuunit
commented on June 11, 2024
We can test it I know that in the past GitHub Actions on PRs have been quite restricted because of security reasons. To prevent malicious PRs to make changes to the base repo or get access to repo / org secrets.
from github-activity-readme.
Related Issues (20)
- Make an empty commit if 50 days have elapsed since the last commit HOT 5
- [ Feature ] Display the date at which the activity happened HOT 3
- `GH_USERNAME` input param is not documented HOT 4
- Support for multiple GH_USERNAME HOT 4
- Actions failing abruptly on upstream repo HOT 2
- My github profile is not updated HOT 2
- Event `undefined` is not supported by this action. HOT 1
- my workflow for recent activity is not working. HOT 11
- option to limit listed events such as PRs
- Support private events in the future? HOT 1
- The action is valid, but the info is not displayed HOT 1
- Is this repository still maintained HOT 1
- [Error] fatal: Error: Invalid status code: 1 HOT 5
- fatal: No PullRequest/Issue/IssueComment events found HOT 1
- ReadMe update failing HOT 7
- Not able to find README.md file HOT 2
- Unable to update README file HOT 6
- Looking for maintainers HOT 3
- The URL generated for `releaseEvent` is invalid HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from github-activity-readme.