Git Product home page Git Product logo

Comments (16)

jalapic avatar jalapic commented on May 24, 2024

Hey thanks. The best way to help would be to provide a csv or excel file with all the results. That can be uploaded here. If you have deeper knowledge of R, you can add directly to the package via a pull request. If not, then a csv or excel file is fine and I can add to the package.

from engsoccerdata.

sibusiso16 avatar sibusiso16 commented on May 24, 2024

Hi James. Thanks a lot. Currently I have 2017 results. Can I send you this while I work on the previous seasons or should I send you all the seasons at one go?

from engsoccerdata.

jalapic avatar jalapic commented on May 24, 2024

yes, please send that - e.g. upload to a gist would be fine. Then I can see what format it is in and make suggestions. To put into the package though, we'll do all at once.

from engsoccerdata.

sibusiso16 avatar sibusiso16 commented on May 24, 2024

Hi James. Here is a gist link to the 2017 South Africa PSL. https://gist.github.com/sibusiso16/99b54fd727c697b62a0f491ee886395c. I tried to follow the format with variable names.

from engsoccerdata.

jalapic avatar jalapic commented on May 24, 2024

looks great - thanks. Yes, that will work well. One thing to be careful of when collecting multiple seasons is to make sure that the teamnames are consistent across seasons. e.g. if the name has "FC" in it in 2017, make sure it's the same for all seasons - this helps users when doing searches across years.

thanks

from engsoccerdata.

sibusiso16 avatar sibusiso16 commented on May 24, 2024

Thanks a lot. I will work on all the seasons and keep the names the same. :-) Thanks again

from engsoccerdata.

sibusiso16 avatar sibusiso16 commented on May 24, 2024

Hi James. I trust you are well. Here is the link to the data for South African's PSL results since 2008, https://gist.github.com/sibusiso16/8346326c482bb38c50559faebb5110a6. I did make the mistake of adding "FC" to one team and i didn't include it in other seasons. But i did fix it. Thanks...

from engsoccerdata.

sibusiso16 avatar sibusiso16 commented on May 24, 2024

Hi James. I have updated the South Africa's PSL results. Now it's from 2002. 2002 is the year in which the league was reduce to 16 teams from 18 teams.

here is the link with the updated results...
https://gist.github.com/sibusiso16/64f1666ce90f24b436c4162d5ef0debf

from engsoccerdata.

sibusiso16 avatar sibusiso16 commented on May 24, 2024

Hi James. I trust you are well. I just wanted to know how do you update your data on your package?

from engsoccerdata.

jalapic avatar jalapic commented on May 24, 2024

sorry - got busy, but will do this tonight !

from engsoccerdata.

sibusiso16 avatar sibusiso16 commented on May 24, 2024

Hi James. Thanks. Can I provided you with the updated csv that will include this weekend’s games? Going forward how will I provide you with scores? Do I need to regenerate the csv with the full history?

from engsoccerdata.

pssguy avatar pssguy commented on May 24, 2024

@jalapic any ETA for this? I'm hoping to visit soon

from engsoccerdata.

jalapic avatar jalapic commented on May 24, 2024

@sibusiso16 @pssguy OK ! Sorry for the delay - it should work now and be on the most up to date GitHub version. Thank you for your help and contribution!

from engsoccerdata.

sibusiso16 avatar sibusiso16 commented on May 24, 2024

Thanks a lot James.

Here is the link to the updated data (up-to 26-11-2017) https://gist.github.com/sibusiso16/c86d9aef97cbf804b0a66b7e57fc6900

How do I provide you with the updates going forward?

from engsoccerdata.

jalapic avatar jalapic commented on May 24, 2024

The best way is to make a function that will directly scrape just this seasons (or the current season) data. That way, the older season data never changes but it's easy for users to get the current data without having to update the package after every result.

from engsoccerdata.

pssguy avatar pssguy commented on May 24, 2024

@sibusiso16 @jalapic Thanks for addition

from engsoccerdata.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.