Git Product home page Git Product logo

Comments (5)

jalapic avatar jalapic commented on May 24, 2024

I haven't had time to update the 2017 and 2018 seasons yet - I really should. The 2016 data is there as you can see from this:

print(england %>% 
        filter(Season %in% c(2016),
               tier %in% c(1)) %>% 
        mutate(Date = as.Date(Date)))

This function gets you the 2018 data:

england_current(Season = 2018)
and it should work for the 2017 Season too, but I just checked and it's messing up the dates (giving the wrong year as 2020).

Unfortunately, I haven't the time to fix all of this for a month or so - hopefully then I can get round to it. Sorry until then.

from engsoccerdata.

Naxulanth avatar Naxulanth commented on May 24, 2024

Hello,

Running this code gives me an empty table

print(england %>% 
        filter(Season %in% c(2016),
               tier %in% c(1)) %>% 
        mutate(Date = as.Date(Date)))

Same with 2017, but 2018 works, which is why I thought something could be wrong and created the issue.

I've also seen commit messages mentioning that it was updated for 17/18, felt like there was an oversight in the code rather than data simply not being there 😄

Thanks for your time!

from engsoccerdata.

jalapic avatar jalapic commented on May 24, 2024

The raw data has been updated to the 2018/2019 season - as I can see here - https://raw.githubusercontent.com/jalapic/engsoccerdata/master/data-raw/england.csv - I'm just working out why the .RData file (The one that supplies the england dataset to the package) doesn't seem to have that data updated. Hopefully will fix asap.

from engsoccerdata.

daviddalpiaz avatar daviddalpiaz commented on May 24, 2024

The raw data seems to still be missing recent seasons, in particular 2016 and 2017. (2018 is present.) After reading in the data-raw/england.csv mentioned above, we can look at the recent seasons:

> tail(unique(england$Season))
[1] 2011 2012 2013 2014 2015 2018

from engsoccerdata.

RobWHickman avatar RobWHickman commented on May 24, 2024

raw data fixed now. Ive just realised for some reason it's decided that a load of Premier League matches for 2017 took place in 2020, I'm hoping this is just some random openoffice error when putting data together manually and will try to fix tonight with a new PR

from engsoccerdata.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.