jakubnabrdalik / hentai Goto Github PK

Just a simple question. Shouldn't FilmFacade constructor be defined as package private? Right now it is defined as public but client code cannot instantiate it with it because it's dependencies are package private so client code (for example in different package) cannot use it. It can be instantiated only by using Spring and having FilmConfiguration class scanned.

https://github.com/jakubnabrdalik/hentai/blob/master/hentai/src/test/groovy/eu/solidcraft/film/domain/FilmSpec.groovy#L21

Literówka w 21 hen a powinno być pewnie when :)

Hi.Could you explain how to implement FilmRepository without SpringDataJpa and InMemory?
Should FilmRepository be public then? Should the implementation FilmRepository then be in the infrastructure package?
How can I do this while keeping the current package structure and package scope? Could you give an example?

Wprowadzasz w błąd.

Gdzie umieściłbyś abstrakcje do zewnętrznego serwisu? Np. pobieranie filmów z jakiegoś external provider'a.

Hi, My next question will be about CQRS.
I would like create excel/xml/csv report contain all films(or selected films).
This service will be based on query repository. Am I right? I would like generate report and next presentation this report over http( for example as rest).
First step will create package "query" and "FilmQueryRepository" (like Articles in your presentation https://youtu.be/ma15iBQpmHU?t=1273)
How can i implement excel/xml/csv service based on FilmQueryRepository? Should I implement this service in film package or create separate package "report" and call facade/QueryRepository from films?
I want to have still package scope. You mentioned that facade should one entry into module. When i implement this service into query package then will be public repository and service(i am going use this service in endpoint). Could you recommended any idea how can i implement this right way and still have package scope?

Wouldn't be better to leave domain (FilmRepository) free from DTO concepts (FilmNotFoundException) ? i.e.:

interface FilmRepository extends Repository<Film, String> {
    Film save(Film film);
    Optional<Film> findByTitle(String title);
    Page<Film> findAll(Pageable pageable);
}

and throw FilmNotFoundException from FilmFacade:

public FilmDto show(String filmTitle) {
        requireNonNull(filmTitle);
        return filmRepository.findByTitle(filmTitle)
                             .map(Film::dto)
                             .orElseThrow(() -> new FilmNotFoundException(filmTitle));
}