In quite a few places context is passed between functions unnecessarily, sometimes just to display an error message. This can cause a memory leak, and is just generally messy anyway.

Currently all preferences are wiped when the app is uninstalled, as early in development prefs were used to keep track of downloaded images.

This is no longer the case, so settings should be backed up.

Having ProGuard enabled (and checking nothing is broken of course...) would allow for smaller APK sizes.

If an image fails ratio criteria, or is a video, the user should have the option of receiving the notification anyway.

Currently, it's hard to tell if the app has just broken or today's content is invalid.

When a new image is pulled and set as a wallpaper, older images could be deleted to save space.

Some pics just dont work as a background, e. g. The black and white line drawing from a couple of weeks ago. It would be nice to have button to ignore the current pic and revert to the previous selection. This sort of happens already with the videos.

Should be done in the same place as the existing greyscaling.

Hi!
Today, if we want to open the APOD image of yesterday, we have to open the calendar and select the date of yesterday. And we have to repeat this each time we want to see the previous image.

Of course the calendar is a great idea if we want to jump to a specific day, but I think we should swipe from left or right if we want to browse on a day to day basis.

I hope I've been clear enough as English isn't my native tongue.

Regards,

Benjamin Larue

Hi,
First thank you very much 😁 for this app.
Then the trouble : when I download an image as wallpaper that appears to be also the lock screen image. Hopefully not the reverse 😉.
Best regards,
Baual

Already started: https://github.com/JakeSteam/APODWallpaper/tree/feature/multi-endpoint, first alternative will be Moon Minute Monday.

Tasks:

• Decouple all code / endpoints / parsing from APOD
• Support XML endpoints (for RSS)
• Improve XML parsing
• Support non-daily checking
• Add new icon
• Update all strings, including app name

Today's image is a fantastic picture of the moon, but the app silently fails to set it as background. I'm guessing it's because of the size, 21M.

https://apod.nasa.gov/apod/image/2301/MoonEnhanced_Mirza_4085.jpg

Currently the app will not work if power saving mode is on. Power saving mode can be easily detected, so this should be used to display a warning to the user.

This warning should state the app may not work correctly, and try to help the user add the app to an "excluded apps" list.

When images are set as a wallpaper, some users might prefer always viewing the whole thing. Currently, the image "fits" itself, losing some of the content off-screen.

As per email discussion, change sharing dialog from:

HD image, Image, URL

To:

Image, URL

Where Image opens another dialog with HD / Non-HD options, and URL opens another dialog with Direct link / APOD page link options.

Currently all downloads happen to a predetermined internal directory, the app should also be able to save to an external directory.

Ideally it should also handle moving existing APODs to avoid redownloading them unnecessarily.

Current % based approach is counterintuitive, but preference library doesn't seem to support floats. Overriding the UI when the value changes might work.

Currently it's an untestable, randomly sprawling mess. Rewriting it into an MVP / MVVM architecture would mean others can work on it, and tests can begin being added.

Since Firebase JobDispatcher is deprecated, the app should migrate to WorkManager.

There is a guide, but will require a lot of changes to the scheduling.

For example, if the date is set a week in advance.

Solution is to handle more than 1 DateRequestedException safely.

https://console.firebase.google.com/u/0/project/apod-wallpaper/crashlytics/app/android:uk.co.jakelee.apodwallpaper/issues/5c5e9cb9f8b88c2963343fe4

A nice improvement would be the ability to filter images according to a colour / brightness criteria. For example, only use images that are more dark than light.

A little homescreen widget would be a nice alternative way to see an APOD!

As this app is a greate opensource app, I'd love to see it on F-Droid.

EDIT: Still this app doesn't use only FLOSS libraries, but a fork without all that crap and using something like Android Jetpack Workmanager instead of Firebase Jobdispatcher which got deprecated anyway would be able to be included

For example, if set to a step of 10, it should move by 10 at a time, not.. ignore this hint.