jakesays-old / ncrontab Goto Github PK

What steps will reproduce the problem?
1. Build the solution
2. Run unit test without attaching debugger


What is the expected output? What do you see instead?
Expected: green result
Instead: DontLoopIndefinitely is red

What version of the product are you using? On what operating system?
NCrontab 0.2


Please provide any additional information below.
Body of TimeCron should be changed:

if (worker.Join(!Debugger.IsAttached ? (int)limit.TotalMilliseconds :
Timeout.Infinite))

instead of

if (worker.Join(!Debugger.IsAttached ? limit.Milliseconds : Timeout.Infinite))

=> use the TotalMilliseconds property of a TimeSpan .

The current release implementation (version 0.2) of 
NCrontabViewer.MainForm.Diff does not work with DateTime-Strings of specific 
locales. Example: try to use the application on a computer with German locale. 
Reason: the length of the short weekday name is just 2 (not 3).

Possible workaround:

Change line 138 of MainForm.cs to
var timeString = occurance.ToString("ddd dd, MMM yyyy HH:mm", 
CultureInfo.InvariantCulture);

http://code.google.com/p/ncrontab/source/browse/tags/0.2/src/NCrontabViewer/Main
Form.cs#138

What steps will reproduce the problem?
1. Run the unittests in NCrontab 0.2 without debugger attached.
2. DontLoppIndefinitely will fail.

Expected results:
DontLoppIndefinitely test should pass

Actual results:
The test fails with the message "The test did not complete in the allocated 
time".

Suggested fix:
Issue is in NCrontab.Tests.CrontabSchduleTests:256:
if (worker.Join(!Debugger.IsAttached ? limit.Milliseconds : Timeout.Infinite))
since Milliseconds only contains the fractional number of milliseconds (< 
1000). You would probably want something like:
if (worker.Join(!Debugger.IsAttached ? (int)limit.TotalMilliseconds : 
Timeout.Infinite))

On a computer with (swiss-)german regional settings, an exception is 
thrown in the viewer.
Problem: Date to string conversion use current culture, but after 
conversion, the day string has not always 3 letters

Please sign the ncrontab assembly in nuget! I'm currently signing and 
maintaining my own version because I need to reference it in a signed assembly. 
Thanks :)

What steps will reproduce the problem?

1. Create the following expression:
    '10 1 * * *'

2. Use the following start and end DateTimes:
    START: 3/2/2010 1:10:00 AM
      END: 3/2/2010 1:15:00 AM

What is the expected output? What do you see instead?
   Expected Results: 1 match
   Actual Results: no match at all


What version of the product are you using? On what operating system?
   AssemblyVersion("0.2.10124.0")
   AssemblyFileVersion("0.2.10124.1211")
   Windows XP / .NET 3.5

Please provide any additional information below.
   -

What steps will reproduce the problem?
Use NCrontab to get the next occurrence after 2012-01-27T12:23:37 for the 
following two expressions:
- "30 1 * * Sun-Sat | UTC"
- "30 1 * * Mon-Sun | UTC"

What is the expected output? What do you see instead?
Both expressions say "1:30 A.M. every weekday", so the expected output is 
2012-01-28T01:30:00. But the second expression yields something else (29th 
instead of 28th). I assume that NCrontab treats "Mon-Sun" (numerical: 1-0) as 
"Sun-Mon" (numerical: 0-1) which is not really what I would expect!?

What version of the product are you using? On what operating system?
NCrontab 1.0

Hello,

is it possible to extend the expression to seconds?
I did it now for myself, but it would be nice if this can be switched on and 
off in the original sourcebase.

Thanks a lot for your work,
Mandy