jakejscott / humidifier Goto Github PK

Example here: http://docs.aws.amazon.com/step-functions/latest/dg/tutorial-lambda-state-machine-cloudformation.html#lambda-state-machine-cfn-step-2

How would I go about adding support for AWS SAM into your library?

Basically it's a kind of self-expanding CloudFormation template transform that introduces new CLoudFormation types such as AWS::Serverless::Api and AWS::Serverless::Function

https://docs.aws.amazon.com/lambda/latest/dg/serverless_app.html

I see that you're using the namespace to form the Type attribute by replacing Humidifier with "AWS::" so I'm not sure how I can inherit from your classes to add the missing functionality.

Ultimately I'm attempting to insert an AWS::Serverless::Api entry with a "DefinitionBody" property set to a json swagger definition string

Would it be better have string and int instead of dynamic? I can try to make a PR if you accept it.

Will AWS CDK supercede this project?

Adding Statement's to a PolicyDocument is a bit of a chore. Come up with a way to make this nicer.

Since not all Cloudformation Resources have a Tag attribute, but usually have this implemented at some later stage, It would be useful to validate that the current state of the resource does have the Tag attribute, and possibly throw a warning if it was not supplied.

Your thoughts?

Cheers 🍺

Using Humidifier v0.2.15

It doesn't seem to be currently possible to generate a Metadata stack entry. AFAIK, this is only used for the AWS::CloudFormation::Interface resource type which is handled in a really unusual manner.

Metadata: 
  AWS::CloudFormation::Interface: 
    ParameterGroups: 
      - 
        Label: 
          default: "Network Configuration"
        Parameters: 
          - VPCID
          - SubnetId
          - SecurityGroupID
      - 
        Label: 
          default: "Amazon EC2 Configuration"
        Parameters: 
          - InstanceType
          - KeyName
    ParameterLabels: 
      VPCID: 
        default: "Which VPC should this be deployed to?"

See https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-cloudformation-interface.html

http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-product-attribute-reference.html

I'd like to use the nested Attributes class to generate valid Fn::GetAtt expressions. While randomly poking around the Humidifier resource definitions, I noticed that some attribute definitions are incomplete.

For example, Humidifier.AmazonMQ.Broker is missing Arn, ConfigurationId, ConfigurationRevision. Also, BrokerId doesn't actually exist. See AWS::AmazonMQ::Broker documentation page.

Similarly, Humidifier.ElastiCache.CacheCluster is missing ConfigurationEndpoint.Address, ConfigurationEndpoint.Port, RedisEndpoint.Address, and RedisEndpoint.Port. See AWS::ElastiCache::CacheCluster documentation page.

Most of the ones I checked were complete and accurate, so this is not a widespread issue. I did not check all of them, so I don't know if there are additional ones.

Let me know if I can provide additional information. Thanks.

Hey Jake,

Seems in the latest version of Humidifier.Json the VPCEndpoint object takes a VPCEndpointType property.
However the Cloudformation requires VpcEndpointType.

Getting an error: "Encountered unsupported property VPCEndpointType"
And docs show property of: "VpcEndpointType" : https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-ec2-vpcendpoint.html

Cheers