jajm / irssi-rocketchat Goto Github PK

First of all thanks a lot for the recently added thread support.

One enhancement that could increase interest towards this plugin would be sticky threads. Quick mockup about how this could potentially work in the input row:

[channel] some comment into main channel
[channel] /rocketchat reply Pgxbfke5mvSw6j2eY
[channel/Pgxbfke5mvSw6j2eY] commenting in a thread # comment goes directly into thread without /rocketchat command
[channel/Pgxbfke5mvSw6j2eY] another comment
[channel/Pgxbfke5mvSw6j2eY] /rocketchat dethread
[channel] last comment # this would again go to the main channel

In addition to the input row, drawing thread prefixes on the message rows could make the separate row In thread (reply with /rocketchat reply Pgxbfke5mvSw6j2eY <msg>): preamble obsolete (and save a bit of screen real estate). But I don't want to bundle too much stuff into this feature request, so let's leave this as a side comment.

And sorry, can't really contribute in the form of a PR, my C is a bit too rusty.

Hello

I get this error when trying to compile irssi-rocketchat on ubuntu/bionic

cmake .. && make && make install

CMake Error at CMakeLists.txt:28 (target_link_directories):
  Unknown CMake command "target_link_directories".

When sending too many messages to Rocket.Chat, it can respond with an error that look like this:

{
    "msg":"nosub",
    "id":"sub-stream-room-messages-Rxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx",
    "error": {
        "isClientSafe":true,
        "error":"too-many-requests",
        "reason":"Error, too many requests. Please slow down.  You must wait 20 seconds before trying again.",
        "details": {
            "timeToReset":19350
        },
        "message":"Error, too many requests. Please slow down. You must wait 20 seconds before trying again.  [too-many-requests]",
        "errorType":"Meteor.Error"
    }
}

If it happens, we should wait and retry

What would eventually be handy is tab-completion for the thread ID's: /rocketchat thread abc[TAB]. I would basically like to avoid using the mouse altogether and currently am using it to select the ID for copypaste. Unsure what kind of memory usage this would entail e.g. would one need to get all of the channel's threads (presumably quite heavy op) or possible to limit just to the threads on-screen.

Originally posted by @junousi in #8 (comment)

/rocketchat channels seems to only list the first 100 channels in alphabetical order. Any possibility of listing more?

Hello
Please add libssl-dev to the list of dependencies for the compilation of libwebsockets

These messages must be ignored

Hello
Compilation error on ubuntu/focal ; cmake 3.16.3

cmake .. && make && make install

CMake Error at CMakeLists.txt:3 (project):
  No CMAKE_CXX_COMPILER could be found.

  Tell CMake where to find the compiler by setting either the environment
  variable "CXX" or the CMake cache entry CMAKE_CXX_COMPILER to the full path
  to the compiler, or to the compiler name if it is in the PATH.


-- Configuring incomplete, errors occurred!