jaisonfdo / bottomnavigation Goto Github PK

Hi,
Firstly, thank you to teach us android. We realize how much effort to put to create repo, atricale and such post. Honestly, salute you for your job 👍 💯

Well I want your response on this your below code mention code from this site . The example is working perfectly but what I have view that the below use is useless ? Why are you again attaching pageChangeListener ?

 viewPager.addOnPageChangeListener(new ViewPager.OnPageChangeListener() {
            @Override
            public void onPageScrolled(int position, float positionOffset, int positionOffsetPixels) {

            }

            @Override
            public void onPageSelected(int position) {
                if (prevMenuItem != null) {
                    prevMenuItem.setChecked(false);
                }
                else
                {
                    bottomNavigationView.getMenu().getItem(0).setChecked(false);
                }
                Log.d("page", "onPageSelected: "+position);
                bottomNavigationView.getMenu().getItem(position).setChecked(true);
                prevMenuItem = bottomNavigationView.getMenu().getItem(position);

            }

            @Override
            public void onPageScrollStateChanged(int state) {

            }
        });

First of all, thanks for the sample project.

I find a direct problem with the approach you showcasing on this project. If you set an item of the view checked "manually" you lose the item selection animation of the BottomNavigationView forever. (Even if you switch pages using the swipe gesture over the viewpager).

That happens because marking an item as checked makes the selector to display it as selected instantly, but you are not really using the bottom navigation internal navigation methods (those are private).

Did you find any way to solve this ?

Thanks.