API of Config->set, get to replace str, int, bool about p5-git-raw HOT 7 CLOSED

This seems reasonable, here are my thoughts:

• Multi-var values should be passed directly on the stack instead of via a list reference.
• The options controlling the behaviour of set should be the first argument after 'key'.
• Add an unset method instead of passing undef to set. unset should return the value(s) that was set.
• I would implement the existing str, int and bool in terms of set and unset.
• I would define constants for the "type" i.e. type => 'str' would become Git::Raw::Config->STRING

from p5-git-raw.

I'm not really a fan of putting the options directly after the key. If you wouldn't use the options, you would get something like set('foo', {}, 'value') which doesn't look nice, or undef instead of {}.

from p5-git-raw.

The other way to do it is to make it the (optional) first parameter to set.

from p5-git-raw.

I am curious about why you want this, it has the same rather inconsistent API. The options are optional and aren't needed per se to set the value. So why they come first is something I do not understand.

from p5-git-raw.

I want any key and values to be adjacent, so that the following works:

my @keyAndValue = ('key', 'value');
$config->set ({options1 => 1}, @keyAndValue);

If the optional options argument slices key and value the above won't work.

from p5-git-raw.

I guess you could also make it work by putting the options last. It actually doesn't matter that much...

from p5-git-raw.

Feel free to make it the last argument.

from p5-git-raw.