Test failure with libgit2-dev 1.3.0 about p5-git-raw HOT 9 CLOSED

This is due to the Debian maintainers replacing the bundled copy of libgit2 with a copy that was built externally. You're lucky that this is the only fallout.

Playing outside of the parameters and scope of the module does not constitute a bug with this project.

If you feel that the copy of libgit2 bundled in the distribution is outdated or is lacking something, feel free to open a pull request to update to a more recent version.

from p5-git-raw.

from p5-git-raw.

Thank you. It is something I'm aware of, they get picked up by the test/release process currently, and does require me to change 2 or 3 lines of code during each minor bump.

from p5-git-raw.

Any news?
If you can point to the couple of lines that needs changing we can apply the change as a patch to the Debian package until it is release officially.
Thanks!

from p5-git-raw.

@real-dam The patch is already available. If I apply it to the main branch, it will result in test case failures. An upgrade of the bundled libgit2 library is required, which isn't as simple as changing 2 or 3 lines of code due to compatibility issues I would need to take care of, document, fix or whatever.

from p5-git-raw.

Hey there,
Just a little headsup, libgit2 has 1.4.3 as its latest version and the same has been already uploaded to Debian experimental. So I think it would be better to bump (if you're planning to do so) the bundled libgit2 version to the latest so as to avoid extra work or you can point us to the relevant patch that supports the upgrade and it can be applied to the Debian package so that things we'll be smooth in Debian and you can work on the official release at your ease.

from p5-git-raw.

@mdb571:

ibgit2 has 1.4.3 as its latest version and the same has been already uploaded to Debian experimental. So I think it would be better to bump (if you're planning to do so) the bundled libgit2 version to the latest so as to avoid extra work

Using bundled libraries is a strong no-go in Debian, at least if the bundled library is packaged already in Debian.

And actually bundling it adds additional security-maintenance (and responsibility) to the developers as well as to anyone using it.

from p5-git-raw.

Just because its the Debian way doesn't mean the approach works for other people. As per my previous comment, if you feel that something should change, please submit a PR, bearing in mind, that this gets used on numerous other systems.

Also bear in mind that this package predates any stable releases from libgit2, hence the pinning to a specific commit.

from p5-git-raw.

Version 0.89 has been compiled against 1.5.0 of libgit2.

from p5-git-raw.