jacobmcauley / playlist_import Goto Github PK

Foundry v9
Pathfinder 2e v3.7.1.10801

Module Version: v1.7.3

Describe the bug
Clicking "import playlist" doesn't import any of the directories into a playlist.
Number of playlists imported shows as /24

To Reproduce
Steps to reproduce the behavior:

1. Go to the playlist tab
2. Click on "Import Playlist"
3. click on "begin import" on the pop-up.
4. Dialogue box pops up with "0/0 operation completed" very quickly and self-closes.
5. "Playlist importer has completed it's task" pops up - Click "tick"
6. Number of playlists completed /24 pops up
7. 

No new playlists are seen in the playlist tab.

Expected behavior
each of the directories should be represented by a playlist folder with tracks listed in each.

Screenshots
If applicable, add screenshots to help explain your problem.

Browser:

• Chrome

Foundry Version:

Game System:
Pathfinder 2e

Additional context
I disabled playlist expander to make sure this isn't interfering with the module but it's the same either way.

if you click the button with the console open, there is an error message:

Which points to this section of code:

// let finishedDirs = 0; //$('#total_playlists').html((localDirs.length)); let dirName = resp.target; let playlistName = PlaylistImporter._convertToUserFriendly(PlaylistImporter._getBaseName(dirName)); let dirNameCustom = dirNameParent ? dirNameParent + '_' + playlistName : playlistName; if (game.settings.get(PLIMP.MODULENAME, 'maintainOriginalFolderName')) { dirNameCustom = playlistName; } let myPlaylists = game.playlists.contents.filter((p) => p.name === dirNameCustom) || []; let myPlaylistExists = myPlaylists.length > 0 ? true : false; if (myPlaylistExists) { **dirNameCustom = dirNameCustom + '-' + myPlaylist.length;** }

Specifically this part where it says myPlaylist is not defined, should it be myPlaylists ?

dirNameCustom = dirNameCustom + '-' + myPlaylist.length;

not finding the option to upload using a URL.

As an alternative to #9 add an option that deletes all existing playlist folders before importing. This allows maintaining a clean slate before importing each new instance of the music directory.

Module Version: v1.7.5

Describe the bug
When I import the playlist first time everything is great.
When I do it the second time, the playlist have the name like <original>-1
If I do it again, the playlists with names like <original>-1 are updated.

Expected behavior
The playlists are imported by their original names <original>, not <original>-1.

Screenshots

Browser:

• Latest Chrome

Foundry Version: Latest 9

Game System: Tested on Starfinder, but I have this issue in different systems.

Additional context
~50 modules, but this is the only module that's related to sound.

Importer was working great with version 0.7.10. After updating to Foundry 0.8.6, it is no longer functioning.

Nothing happens after clicking on "Begin Import".

Hosted locally.

Module Version: v1.0.0

Describe the bug
Doesn't seem to do anything.

To Reproduce
Steps to reproduce the behavior:

1. I select the folder in settings.
2. I save settings.
3. I click Import Playlist
4. it says 0/0 imported

Expected behavior
I expect it to work as shown in the video

Screenshots
If applicable, add screenshots to help explain your problem.

Browser:
Brave v1.42.97 (Aug 17th, 2022)

Foundry Version:
9.x

Game System:
d&d5e

Additional context
No other modules installed.

name: Bug report
about:
title: ''
labels: ''
assignees: ''

Describe the bug
Playlist Importer will not save or import from directory.

To Reproduce
Steps to reproduce the behavior:

1. Go to "Module Settings"
2. Select appropriate directory with organized folders of music within.
3. Click Save Changes and window closes
4. Click the "Playlist Import" button on the playlist tab and then "Begin Import"
5. Window closes and nothing happens.
6. Go back and check the "Module Settings" tab in "Configure Game Settings" to find that the "Base Music Directory" has been switched to "[object Object]"

Expected behavior
For the Playlist importer to pull from the selected Directory and start importing when prompted.

Screenshots

Desktop (please complete the following information):

• OS: Windows 10
• Browser: Chrome
• Version: Foundry 0.8.8

Describe the bug

Playlist importer can't import my S3 playlist

Screenshots

I'm using FoundryVTT 0.7.10 (hosting it at AWS) and using Playlist Importer version 1.6.1.

Hi! I've been using your awesome module for some time and I love it!
I've just started using S3 and i can't import my playlist with your module. I have correctly set up the S3 information needed in the foundry setup and I am already using it for various assets, I can even add music that is located at my bucket manually.

When I try to use Playlist Importer, i set the bucket name as indicated at the read.me instructions, but when I hit "Import Playlist" nothing happens.

My S3 folder structure right now is "s3://fakebucketname/Audio/Music/". The "playlist" folder are inside /music/.

If i leave "base music directory" empty, it imports my /data/ folders at my AWS VM, if I select the S3 Playlist folder nothing happens.

Is this a bug or i'm doing something wrong? Can you put more pictures and examples (or maybe a youtube video) of how to configure the module for S3 buckets at the read.me section?

Thanks!!

https://github.com/JacobMcAuley/playlist_import/blob/master/src/main.js#L114

Right now the defaults are repeat: true, lvolume: 0.5 of which both defaults should be able to be changed (or even just repeat since that's what is available during sound creation normally).

Is there any chance that "Nested folders will result in unsuccessful importations. This will be addressed in future builds" can be addressed. This would make it even more useful for categorisation.

Here it is:

Core 0.6.6
Playlist importer 1.5.1
Language set to english:

Hi there!

Firstly, thanks for the creating this module. It is amazing!

I was wondering if it was possible to add support for importing from other sources such as GitHub, GitLab or even JukeHost.

I run foundry locally, but I like to store my songs in a external source to save network bandwidth. The downside of this process is to not being able to import complete playlists. I need to add the songs individually.

This functionality would be a great helper! But I don't know if its even possible to do so.

Again, thanks for you amazing work!

whenever I click on the playlist import, every folder will be created once again, since I checked the duplicate checker, those new folders are empty, but it's time-consuming to delete them, it's seems that duplicate check is not applied to folder level

the duplicate folder should not be created again

I'm running on windows
FVTT: 9.249
Playlist impoter: 1.7.1

I have a bunch of audio folders in the "MP3" folder of "Data". I am using Forge to host my game as well.
It will import and populate two or three playlists from the MP3 folder and then stop leaving the rest of the playlists imported but completely unpopulated.
All files are in MP3 formate and uniquely named.

Describe the bug
The Directorypicker used on the form settings for get the path of the "folder dirs root", it's not working it's keep telling me:

Uncaught (in promise) Directory [object Object] does not exist or is not accessible in this storage location

To Reproduce
Steps to reproduce the behavior:

1. Go to 'Module settings' of the module
2. Click on the Directory picker of the 'Base Music Directory'
3. You can already see the value '[object Object]' and you can't change the value because it' still go to the value '[object Object]' .
   
4. I debugged the code and change the string '[object Object]' with the path to the directory and all it is work fine

Expected behavior

I want when i selected the folder with the picker on the path data/mymusic to see the string 'data/mymusic' on the 'path' variable at the line of code
https://github.com/JacobMcAuley/playlist_import/blob/master/src/main.js#L381

Screenshots

Desktop (please complete the following information):

Foundry VTT Version: 0.8.8

Operating System: [Linux], [Window]

How Are You Using Foundry: [Linux,Native Application (Electron), Chrome], [Window,Native Application (Electron), Chrome]

Which Game System: Dungeons and Dragons 5th Edition, version 1.3.6

Modules Enabled?: yes

Module version: 1.6.1

OS, Hosting, Browser (if applicable): Linux/Node/Chrome

Additional context

While I'm just using this as staging to make my own compendiums, this might surprise some people.

Describe the bug
When I try importing my music folders to Foundry VTT, it imports all the folders, but only the music files in the first folder.

To Reproduce
Steps to reproduce the behavior:

1. Leave the music files in the folder that the documentation mentions (Data/music/).
2. Leave a folder inside /music/ for each genre, and put the music you want inside each one of them.
3. Made sure to leave no spaces in folders' names, nor duplicates across folders, or files that aren't supported.
4. Open Foundry VTT > Import Playlist
5. Only the first folder's music will be imported.

Expected behavior
Each folder should have all their music inside, but all the other ones are empty.

Screenshots

Desktop (please complete the following information):

• OS: Windows 10
• Browser Chrome
• Foundry VTT 0.7.9

Module Version: v1.7.3

Describe the bug
after importing the playlist for the first time, I added some new songs into my folder and click the playlist import again, this time the new songs don't show up.

To Reproduce
Steps to reproduce the behavior:

1. click playlist import to import a fresh playlist
2. add some new songs to the existing folder
3. click playlist import again
4. new songs don't show up

Expected behavior
the new songs should show up after clicking playlist import again

Foundry Version:
v9 255

Game System:
dnd 5e

Additional context
Add any other context (like other modules installed) about the problem here.

Attempting to import gets a 0/x playlists imported. Nothing happens. Tried clearing the memory, still nothing. x is equal to the number of folders, so it sees the folders. With V9 on Windows.

Module Version: v1.7.3

Describe the bug
Import Playlist button just isn't there.

To Reproduce
Steps to reproduce the behavior:

1. I've enabled the module
2. Click the playlist tab.
3. No button.

Expected behavior
I hope to see the button

Browser:
Chrome

Foundry Version:
9.251

Game System:
dnd5e

Additional context
I tried disabling Blitz's Soundboard to no effect.

Whenever I try to update the module through Foundry, I'm getting this popup saying the Manifest URL has changed, but even when I click yes, the popup still appears the next time I try to update.

It goes through the motions of a progress bar, and then gives this success popup, but rest assured, if I click the update button again, I'll get the same Manifest URL popup.

Is it possible to import the folders recursively?
Like if I had in my folder structure something like

To import it in order to make the folders as playlist folder and, then if there's music in the folder create a playlist for that with the same folder name?

A folder with music starting with a number (example: "29th planet") will have the number removed when imported as a playlist (so the result is "Th planet").
Expected result is to keep the number.

I am unable to upload playlists from folders located within my data folder. Attached is a screenshot of the error

Describe the bug
playlist_import preventing 'Configure Settings' window to open with FoundryVTT

To Reproduce
Steps to reproduce the behavior:

1. Go to 'Settings' tab
2. Click on 'Configure Settings'
3. Check console errors

On each separate Foundry instance launch, when entering a world with playlist importer on, reimport the folders to add new additions added, skipping already imported songs.

Please implement in settings to import all songs with streaming mode turned on or off.

Please add the framework for translating the module to other languages (as other modules do, with an en.json file in a lang folder with keys that we can translate).

I have translated more than 10 modules and this one doesnt support translating.

Thanks and great work!

the settings-extender module needs to be updated to its latest release in order to not break the config settings in 0.5.4

See https://gitlab.com/foundry-azzurite/settings-extender/-/issues/3

Thanks!

Describe the bug
When the playlist is imported the first imported folder (alphabetically) is bugged and does not play on shuffle properly. Instead of shuffling tracks upon pressing play the order is created upon importing and added to (its end) when new tracks are added resulting in exactly the same play sequence of the list upon shuffle.

This can be "avoided" by creating a folder with no tracks such as AAA which gets imported first and gets bugged instead of something like "Ambience". :)

To Reproduce
Steps to reproduce the behavior:

1. Create any folder with 2 or more songs to be imported.
2. Import with Playlist Import module.
3. Play the playlist repeatedly... The tracks should reshuffle in between the clicks to "start playing" every 5+ seconds or so...

Desktop (please complete the following information):

• Foundry version 0.7.9 running in Docker
• Chrome Version 87.0.4280.88 (Official Build) (64-bit)

Describe the bug
Playlist Import places %20 in playlist names instead of spaces.

To Reproduce
Steps to reproduce the behavior:

1. Go to VTT Music.
2. Click on Playlist import.
3. Wait for import of playlist with spaces in name.
4. See error

Expected behavior
Spaces should not be encoded.

Screenshots

Desktop (please complete the following information):

• OS: Windows
• Browser: Chrome

Additional context
Could be due to the recent update of Foundry or another module. Bug hunting ideas would be appreciated.

If a track was previously added and then deleted, it will not be placed back into the Foundry playlist when "check for duplicates" is enabled.

To Reproduce

1. Create a playlist folder with a few songs
2. Import the playlist in Foundry
3. Delete the playlist in Foundry
4. Ensure "check for duplicates" is enabled in module settings
5. Attempt to import the playlist again
   -Notice that the playlist is listed in Foundry, but there are no songs contained in the playlist.

Expected behavior
"Song Duplicate Checker" should only skip songs that are present in Foundry, not songs that were previously added but are no longer present.

Desktop (please complete the following information):

• OS: Windows
  -Foundry version: 0.6.5

When Skip Duplicates is off due to user wanting to avoid skinning tracks that exist in multiple folders, this causes reimports to create duplicates of the same existing songs.

Instead, when re-importing there must be built-in skipping of already imported tracks independent of whether the user set Skip Duplicates or not.

With 0.6.1 released on 31/5, setting-extender.js has critical compatibility issue that prevents users from accessing the Settings in their Foundry if even one activated mod has the old settings-extender.js. I checked the mods that haven't been fixed yet and use setting-extender.js and wanted to let you know that @Azzurite has released a fixed version, all you need to do is replace and re-publish. From the Discord release post:
settings-extender 1.1.3

Link: https://gitlab.com/foundry-azzurite/settings-extender/
Direct Download: https://gitlab.com/foundry-azzurite/settings-extender/-/raw/1.1.3/src/settings-extender.js

Fixes a compatibility issue with 0.6.1. Module authors have to update their usage of this. If you're a user and want to use your favorite modules on 0.6.1 immediately, you have to either wait for them or manually replace one of your settings-extender.js files (only one is enough, the fix will be applied to all of them) with this.

I have songs that belong to multiple playlists and with the current duplicate checking it only adds the songs to one playlist.

https://github.com/JacobMcAuley/playlist_import/blob/master/src/main.js#L105-L110

Instead of trackName in the HashMap being the track, if this option is enabled it should also include the playlist/folder name in the hashed name.

To Reproduce
Steps to reproduce the behavior:
Currently I have the structure "media/audio/" and the importer only imports the names of the folders leaving the playlists empty.

Expected behavior
It would be amazing if you could allow the module to import music up to 2-level deep folders.