jackypan1989 / express-query-parser Goto Github PK

no support for it? :)
btw package is outdated too

I have encountered the following case:
filter[id_test][type]=in&filter[id_test][filter][0]=1&filter[id_test][filter][1]=2&filter[id_test][filter][2]=3&filter[id_test][filter][3]=4&filter[id_test][filter][4]=5&filter[id_test][filter][5]=6&filter[id_test][filter][6]=7&filter[id_test][filter][7]=8&filter[id_test][filter][8]=9

Should be parsed to { type: 'in', filter: [1,2,3,4,5,6,7,8,9]},
Instead i get filter: {0:0, 1:1, 2:2, ... 9:9}

Thx for library man.

I have an issue with integration into inversify stack

Code

import queryParser from 'express-query-parser'

    ...
    inversifyExpressServer.setConfig(async (app: express.Application) => {
        ...
        app.use(
            queryParser({
                parseNull: true,
                parseBoolean: true
            })
        )
    });

Error

[2020-11-17T15:51:48.899] [ERROR] main - TypeError: express_query_parser_1.default is not a function
    at ...\backend\typescript\src\App.ts:110:28
    at InversifyExpressServer.build ...\backend\node_modules\inversify-express-utils\lib\server.js:119:28)
    at ...\typescript\src\App.ts:127:41
    at processTicksAndRejections (internal/process/task_queues.js:97:5) (<anonymous> ..\App.ts:99:27)

P.S.

1. Add github link to npm description plz
2. Add documentation line about ramda package requirement

you need to add the if (target === '') { to your code.

export const parse = (target: ParsedQuery, options: Options): ParsedQuery => {
switch (typeof target) {
case 'string':
if (target === '') {
return '';
} else if (options.parseNull && target === 'null') {
return null;

Hey there,
Thanks for useful helper package

Docs says that all options are "true" by default, which means that I can use it like this:

app.use(queryParser());

but I can't because of typescript, and passing empty object resetting options to undefined ⇾ false

Proposal

Made queryParser argument optional, and set all options to true by default.