jackv24 / comicwrap-f Goto Github PK

Currently an AdMob app ID is required in android/local.properties with adMob.appId=<ID> - the app should build without it (and just not display ads)

Is your feature request related to a problem? Please describe.
Sometimes when a user inputs a URL it is redirected, but the comic document name retains the original URL. This means that if someone else imports the comic using it's redirected URL directly the database will end up with two imports of the same comic.

Describe the solution you'd like
Importing should check the URL against existing comic doc names AND scrape URLs, and match to an existing comic if found.

Describe the bug
All pages seem to be scraped correctly, but their URLs must be redirected or something since navigating only works once.

To Reproduce
Steps to reproduce the behavior:

1. Import comic
2. Open a page
3. Open navigation bar
4. Observe page title displaying correctly, and navigation bar working
5. Navigate using in-page navigation or navigation bar
6. Observe no page title and navigation bar greyed out

Expected behavior
Should continue to display page title and navigation bar correctly when navigating

Required Info (please complete the following information):

• Comic URL: https://hovergirls.com/
• Device: Samsung Galaxy S10e
• App Version: 1.0.0

Comic shows no pages available in app. Comic has next episode, last episode, previous episode, and first episode buttons. Comic also has individual web pages for each page of the comic.
http://www.sssscomic.com/comic.php?page=1
Device is CAT S62
App version is 1.0.0
OS is Android 11

Describe the bug
Exiern Dark Reflections not loading
http://zen.darkreflections.live
has prerequisites: archive, first page, next page

To Reproduce
Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Required Info (please complete the following information):

• Comic URL http://zen.darkreflections.live
• Device: Android (chrome os running Play store apps), Lenovo Duet
• OS: chrome os 99.0.4844.46, which runs Play store under Android 9.0
• App Version 0.5.8

Additional context
Add any other context about the problem here.

Some packages were reverted in 4f0f745 to fix some issues with the comic page list.

Reverted all Firebase-related packages as just reverting cloud_firestore did not fix it.

This may be related to firebase/flutterfire#7396 as the issue seems to be at comic_page.dart:386, where the await never ends if the amount of docs to return is 0 (which always happens when trying to jump to the start or end of the list).

We should upgrade these packages once the issue have been fixed.

Is your feature request related to a problem? Please describe.
Some comics have managed to import properly, but don't display any easy next/previous buttons on the web page. (a few Tumblr webcomics are like this)

Describe the solution you'd like
Add an option for app native next/previous/first/last buttons to be displayed. Make this toggle-able per user.

Describe alternatives you've considered
Detecting if the buttons are present on the website and then automatically displaying the controls could work, but is a lot harder.

Progress:

• Make nav bar
• Centre buttons more on wide screens (like settings page, etc.)
• Make it optional, default off
• Bar colour should match theme of associated ComicPage (top bar too)

Is your feature request related to a problem? Please describe.
Sometimes when reading I'll accidentally tap on something that skips forward many pages. When that happens it sets my bookmark and I lose where I was up to!

Describe the solution you'd like
It would be good to have a history of read pages (local storage is fine) so the user can return to their previous page, and set that as the bookmark.

Is your feature request related to a problem? Please describe.
In the case that an import fails the database ends up littered with failed imports.

Describe the solution you'd like
If an import fails (no pages are scraped) and the comic has been removed from all user's libraries, it should be scrubbed from the database.

Is your feature request related to a problem? Please describe.
The current colour scheme (other than Comic Pages) is sort of random.

Describe the solution you'd like
It would be nice to implement dynamic color, maybe using this: https://pub.dev/packages/dynamic_color

Describe the bug
I imported the comic using the URL "https://www.aliceandthenightmare.com/comic/chapter-one-cover", which resulted in the scrape url being that entire URL. This meant that loading any page will actually result in just ending up at that first page.

To Reproduce
Steps to reproduce the behavior:

1. Go to Library screen
2. Import comic using the URL of any page
3. Tap on comic in Library
4. Tap on any page that isn't the one that was imported
5. Observe the imported page being loaded instead of the one you tapped on

Expected behavior
Should load the correct page.

Use https://pub.dev/packages/blurhash_dart for cover images, to display something interesting while the image is loading.

Is your feature request related to a problem? Please describe.
When a comic has failed to import it is not clear what has happened, the comic just sits in the Library with default empty data.

Additionally, a lot of users attempt to add manga from manga reading websites, when the app only supports webcomics that have their own dedicated website. This needs to be made clearer.

Describe the solution you'd like
After import failure the comic should show an "Import Failure" state in the library, and tapping on it should bring up a dialog explaining the problem instead of a blank details page.

The current centred page is missing from the page list. For example when:

• Clicking "First" button, the first page will be missing
• Clicking "Last" button, the last page will be missing
• Clicking the bookmark, the bookmarked page will be missing
• Returning from reading, the last read page will be missing

Some packages were reverted in 4f0f745 to fix some issues with the comic page list.

Reverted from v1.0.3 to v0.14.0+3. It's likely exactly this issue: rrousselGit/riverpod#601

We should upgrade Riverpod once the issue has been fixed.

Is your feature request related to a problem? Please describe.
Opening the import comic dialog always pastes whatever is in the clipboard, which can be annoying if that's not a URL.

Describe the solution you'd like
We should first check if it's a URL before pasting it.

Describe the bug
Every comic I've entered hasn't loaded. It does direct me to the report a big page, which is nice.

To Reproduce
Steps to reproduce the behavior:

1. Press "Add Comic" button at the top.
2. Enter homepage URL of comic
3. Observe "No pages" thumbnail

Screenshots

Required Info (please complete the following information):

• Comic URLs

• https://xkcd.com/

• https://www.oglaf.com/

• https://cad-comic.com/

• http://www.bardsworth.com/

• Device: Pixel 4a (5g)

• OS: Android 12

• App Version 0.5.8

Additional context
Thanks for working on this. It seems like it could be exactly what I'm looking for.

The Google Play link isn't working. Guessing the app just isn't available yet, so this is more me saying "hey, this looks really cool and I'm hyped to use it (and I can't figure out how to build with Flutter 🙄)” than anything else.

Is your feature request related to a problem? Please describe.
Storing data in Firebase costs money, we we should clean up old unused data.

Describe the solution you'd like

• If a user hasn't logged in for 6 months, send them an email prompting them to log in if they don't want their account deleted.
  • Delete the account 1 month later.
• If no users have had a comic in their Library for 1 month, delete the comic.

Hello there!
I’ve been looking for an app exactly like you’re developing. Do you have a Testflight, or are there any guidelines on how to build for iOS and perhaps contribute to the project?