jack-ji / jok Goto Github PK

Using defer on pairs of setup and cleanup is a common zig idiom, but since the end() functions can error, its impossible right now.

Suggested refactor:

• make an error union variable;
• rewrite the try expressions to catch, save the error and return;
• make begin() try the end error as the first thing;

so it would be something like

+ var end_error: anyerror!void = {};
...
pub fn begin(opt: BeginOpt) !void {
    + try end_error;
    ....
}
...
-pub fn end() !void {
+pub fn end() void {
-    try [expr];
+    [expr] catch |e| return end_error = e;
}

Gonna write down a PR, just thought it would be good to open an issue first.

Right now, if I use any of the functions that use @splat, it causes a compile error:

/home/mpokhil/Source/jok/src/j2d/Vector.zig:97:39: error: expected type 'u32', found 'type'
    const result = self.data / @splat(f32, l);
                                      ^~~
referenced by:
    move: /home/.../src/main.zig:63:30
    update: /home/.../src/main.zig:146:13
    remaining reference traces hidden; use '-freference-trace' to see all reference traces

/home/.../jok/src/j2d/Vector.zig:23:27: error: expected type 'u32', found 'type'
    const result = @splat(f32, val);

Just changing all instance of @splat(f32, ...) in jok.j2d.Vector to @splat(2, ...) works as expected.

Should I create a PR for this?

the build.zig.zon here doesn't let this project compile

Not so sure how other engines/frameworks are dealing with high dpi. Hope someone can provide some clues.

Hi! I'm trying to compile the examples, but I'm getting:

PS D:\programming\__zig\jok> zig build hello
zig build-exe hello Debug native: error: error(compilation): clang failed with stderr: D:\programming\__zig\jok\src\deps\audio\c\sdl_impl.c:594:18: error: call to undeclared function 'ma_context_init__sdl'; ISO 
C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]

The SDL version I've setup is SDL2-devel-2.28.5-mingw