Git Product home page Git Product logo

openpilot's People

Contributors

j-vanetten avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

openpilot's Issues

2020 Jeep Grand Cherokee Fingerprint

Need updated fingerprint from openpilot master
To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

Screen does not turn off, draining the battery

Describe the bug
When running the latest version of jvePilot, the Comma 3 screen does not turn off after shutting off the vehicle, draining the battery until the C3 shuts down fully from low voltage. I notice if I install official OpenPilot, it has me download a 1GB update, and the screen turns off about 20 seconds after stopping the car as expected. However, if I reinstall jvePilot, it has me download a 1GB update again, and the screen never turns off.

This is on a 2017 Chrysler Pacifica ICE.

To Reproduce
Steps to reproduce the behavior:

  1. Install official OpenPilot on C3
  2. Finish setup, and turn off car
  3. Watch screen turn off
  4. Install jvePilot on C3
  5. Finish setup, and turn off car
  6. Screen may dim, but does not turn off

Expected behavior
Screen turns off after shutting off the vehicle.

Downstream forks broken by forced history rewrite

Describe the bug
The current release branch has 7 commits. At some point it's history was rewritten, which has broken any downstream forks.

To Reproduce
Steps to reproduce the behavior:

  1. Fork this repo (before the rewrite)
  2. Try to merge upstream after the rewrite

Expected behavior
When new updates to OP occur, keep the version history and rebase.

Dynamic camera offset (based on oncoming traffic) (From SA)

Saw these in another fork. Thought you might like it.
ShaneSmiskol/openpilot( https://github.com/ShaneSmiskol )

Lane Speed alerts
This feature alerts you of faster-travelling adjacent lanes and can be configured using the on-screen LS button on the bottom right to either be disabled, audible, or silent.

The idea behind this feature is since we often become very relaxed behind the wheel when being driven by openpilot, we don't always notice when we've become stuck behind a slower-moving vehicle. When either the left or right adjacent lane is moving faster than your current lane, LaneSpeed alerts the user that a faster lane is available so that they can make a lane change, overtaking the slower current lane. Thus saving time in the long run on long road trips or in general highway driving!

The original idea is thanks to Greengree#5537 on Discord. This feature is available at 35 mph and up.

Dynamic camera offset (based on oncoming traffic)
This feature automatically adjusts your position in the lane if an adjacent lane has oncoming traffic. For example, if you're on a two-lane highway and the left adjacent lane has oncoming cars, LaneSpeed recognizes those cars and applies an offset to your CAMERA_OFFSET to move you over in the lane, keeping you farther from oncoming cars.

This feature is available from 35 to ~60 mph due to a limitation with the Toyota radar. It may not recognize oncoming traffic above 60 mph or so. To enable or disable this feature, use opEdit and change this parameter: dynamic_camera_offset.

NoPanda issue

Just got my C3 this week. Tried installing from your link four different times, I always get the "NoPanda" error. Reverted to the stock open pilot after each failed attempt and it works fine. Is there a hardware change on the newest C3s that is maybe causing this issue?

Support KM per hour

Is your feature request related to a problem? Please describe.

I love the work you've done with your fork.
But as I live in Canada it would be nice to have the ACC+/- buttons and any other areas where settings are Mile per hour set to work, show and set in Kmph if OP settings are set to metric.

Lkas error white panda

Can error only on remote start only. Regular start is fine. I think the problem is there is no CC.enabled allowed when remote start is active. Not until you push to start is it active. Hopefully there can be a if then else statement. Been working on it for 2 weeks and still hitting a wall. Running 2020 Jeep with WP advanced.

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

LKAS Error when remote start

When i remote start the jeep i get a lkas error with white panda. If i start normal no lkas error

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

Expanding jvePilot settings, then existing out of setting causes settings to disappear.

Describe the bug
Expanding jvePilot settings, then existing out of setting causes settings to disappear when you return

To Reproduce
Steps to reproduce the behavior:

  1. Go to Settings -> jvePilot
  2. Expand ACC Eco
  3. Click X to close settings
  4. Return to Setting-> jvePilot
  5. ACC Eco child options are now missing

Expected behavior
All settings are still available

Auto set user preferred Max Speed

Is your feature request related to a problem? Please describe.
Here's a thought. In the top left corner it starts of with the N/A for max set speed.
What if in the settings we could have a preferred speed we'd like to be auto set to when pressing our ACC on button. For me I would always prefer 65KM as most of our non highway roads are 60KM and OP won't operate below 64km(40mph). Being able to just turn on the ACC then resume when ready would be nice.
Also in regards to this too when we turn off the ACC completely the Max set speed is still displayed. IMO it should display N/A again as the last set Max speed is then misleading when you turn on the ACC again.

Significant Oversteer on lane change at freeway speeds

Describe the bug
A clear and concise description of what the bug is.

  1. This fork steers very rapidly during lane change. In a way no driver would duplicate, It oversteer on my 2017 trailhawk rapidly changing lanes, then lost center lane for confirmation of lane change, the rapidly correctly by steering back into the lane I started from, then locked and went back. This issue happened many times on my trip from Las Vegas to Salt Lake City. Something is wrong. I have a new 3x and I used JVE PILOT on Comma 2 for the last 6 months with perfect lane change and all features working. on comma 3xIt also swerved through two lanes on left lane change and was Extremely unsafe. I don't know why but someone needs to be told something is wrong.

  2. Also on several occasions the set speed was exceeded by JVI Pilot, in one case it kept increasing cruise control even though there was a car in front of me and it couldn't go faster, In anoither case it consistently set the actual speed above the speed I set that shows on the upper left corner of the Comma 3x. This is super shocking to me after owning 2ea comma 2 and always working near perfect, never a random lane excursion, but it just happened today on this trip. I loved your program but its not working on the comma 3x which makes me wonder, is something else wrong? Is my new 3X defective? But it kept lane just fine,but lane change was a nightmare and is unuseable. Im not programmer, but I want to let you know in good faith in case something is wrong.. The extreme lane swerve I encounters made me look like I breifly lost control. I did keep my hand on wheel and catch it, but it happens very fast. My opinion: COmma AI should never be programmed to rapidly apply steering at highway speeds. I kept asking myself "how did this happen" I just spent 1$1250 on 3x and I feel that i can't trust it at all. Never happened with COmma 2. SOmeone should know. I understand its my responsibility etc, and I was careful and corrected this behavior, but someone else might not be so lucky. Also I'm really bummed out I have to uninstall it. now. Its not safe.

To Reproduce

Drive 2017 WK2 with Comma 3X at 77mph on straight road, initial lane change. repeat in different condtions. I MAY LEAVE IT AND MAKE A YOUTUBE TO SHOW YOU. but I should uninstall ASAP.

Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
The steer is way too fast for high speeds, its feels like a child grabbed the wheel and abruptly pulled on it. Its really scary.

[email protected]. I am not a programmer, I just figure out how to load the JVE PILOT and follow your directions 2017 WK2 Trailhawk

Can't install j-vanetten open pilot on my C2

Describe the bug
I had to flash my comma2 for some reason and now when using the bit.ly link to the c2 package, it says an update is needed and when that update is installed, the comma2 seems to just boot loop at the recovery screen

To Reproduce
Steps to reproduce the behavior:

  1. Reflash Comma2 via these steps: https://commasupport.zendesk.com/hc/en-us/articles/4413250576535-Reflashing-NEOS
  2. Used the provide Comma2 link from this page to install j-vanetten open pilot.
  3. Installed j-vanetten screen appears.
  4. Update Required prompt appears and I click Install.
  5. Downloading recovery and Downloading system bars complete.
  6. Bootloop begins.

Expected behavior
I expected the software to install and load as it has done in the past

Additional context
This used to work fine but suddenly began to glitch which led me to refreshing the comma2 and thus beginning this cycle of issues.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.