Git Product home page Git Product logo

examples's People

Contributors

leecalcote avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

examples's Issues

Egress example unnecessarily convoluted?

The example in the book seems overly complicated and hacky compared to what's in the istio docs

The way specified by the docs is straightforward, if involved/possibly redundant:

  • set up a ServiceEntry for the external hostname
  • set up a(n Egress) Gateway exposing that same hostname
  • make a simple destination rule pointing to that gateway
  • have a VirtualService route traffic from sidecars (the mesh Gateway) to the Egress Gateway, and from the Egress Gateway to the external hostname.

The way that you guys have outlined in the book is honestly pretty byzantine in comparison:

  • make a ServiceEntry mapping the external hostname to istio-egressgateway as an endpoint
  • make a Gateway exposing the external hostname, which - as you note in the book! - sends requests in a loop
  • to fix this, have a VirtualService route traffic directed at the external hostname to an intermediate ("fake") hostname...
  • ... which is provided for by yet another ServiceEntry that maps that internal hostname back to the external one that we were trying to reach in the first place.

I'm not sure if you guys were trying to prove a point w.r.t. the power of VirtualServices and Gateways, but if that were the case you should have prefaced it with way more language (hopefully diacritic-heavy for emphasis) indicating that this is not necessarily the recommended way of doing egress.

If I'm missing something incredibly basic, please tell me - otherwise, I feel like this is dangerously misleading and discouraging for readers!

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.