Git Product home page Git Product logo

Comments (7)

aaronabramov avatar aaronabramov commented on September 22, 2024 1

changing it to

if (!Array.isArray(this.exclude)) {
  //  this.exclude = ...
}

shouldn't be breaking. It'll only break if people passed an empty array an an exclude option in the previous versions

from test-exclude.

aaronabramov avatar aaronabramov commented on September 22, 2024

this is probably related to istanbuljs/babel-plugin-istanbul#9

from test-exclude.

aaronabramov avatar aaronabramov commented on September 22, 2024

i can workaround by passing excludes: [/.^/] for now. but that's a little odd and i'd really like to just bypass the check completely :)

from test-exclude.

bcoe avatar bcoe commented on September 22, 2024

@DmitriiAbramov really open to this suggestion, if you can think of an elegant way to approach it -- ideally avoiding a breaking change.

I think it would be cool to be able to cover node_modules, as an example.

from test-exclude.

JaKXz avatar JaKXz commented on September 22, 2024

Want to submit a PR with tests? :)

from test-exclude.

bcoe avatar bcoe commented on September 22, 2024

@DmitriiAbramov that would be wonderful, otherwise I'm hoping Monday and Tuesday will be open source days for me.

from test-exclude.

aaronabramov avatar aaronabramov commented on September 22, 2024

@bcoe yeah. i'll do it!

from test-exclude.

Related Issues (15)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.