support negated glob for node_modules and always exclude node_modules about test-exclude HOT 9 CLOSED

@JaKXz this will be a breaking change 👍 but, I'm convinced by my conversation with @sindresorhus (and by frequent node_modules related issues opened on nyc, that it's a better call for us to always exclude node_modules, as long as we have a work around we can point people to).

from test-exclude.

doesn't this revert #10 ?

from test-exclude.

@JaKXz Read the linked discussion: istanbuljs/nyc#348

from test-exclude.

@sindresorhus I did, but the solution is unclear to me. Anyway, I'm not blocking this issue in any way, was just curious.

from test-exclude.

@JaKXz How is it unclear? Put ["!node_modules"] in the ignore to enable node_modules again.

from test-exclude.

@sindresorhus the "unclear"ness was because I was confused about if we're attempting to support both at the same time [which is slightly impossible 😆 ] - when we were implementing #10 I/we should have remembered how globs work and simply provided that documentation. Thanks for raising the issue.

from test-exclude.

Addressed in + [email protected].

from test-exclude.

@sindresorhus @JaKXz this will be released in istanbuljs/nyc#442

from test-exclude.

@bcoe Awesome. Thanks for fixing :)

from test-exclude.