isoos / buffer Goto Github PK

Null safety is now in beta. I would like to update my package to use null-safety, but I depend on this package.

Any ideas when you will upgrade? I'd be willing to submit a pull request. A quick check with dart migrate seems to provide a decent migration, but I understand if you would like to spend a bit more time and not have as many null asserts.

There are cases when you need to peek ahead for given data, e.g. check for magics and act accordingly.

I encountered this minor problem in a project that reads a p-string (length prefixed) string at the end of a datagram. In one case, the length of the string was 0 and the subsequent read(0) crashed.

Here's a test case that simulates the situation I ran into. Think of [0,0,0,0] as a datagram that contains just one empty p-string.

    test('Zero byte read at end of buffer', () {
      final buffer = [0,0,0,0]; 
      final reader = ByteDataReader();
      reader.add(buffer);
      final strLen = reader.readUint32();
      expect(strLen, equals(0));
      var noBytes = reader.read(strLen);
      expect(noBytes.length, equals(0));
    });

The work-around is to only call read(n) when n>0, but it would be better if read(0) just returned an empty Uint8List.

P.S. Thanks for publishing this library!

Example page is missing in pub.dev

Example of a package with an Example page

It is also subtracting some points from this package