ishuar / terraform-aws-eks Goto Github PK

inconsistent .tf generic file names

• providers.tf should be versions.tf across the repo.
• main.tf should be the entrypoint always

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• chore(deps): update terraform aws to v5

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

• Add README for the private_cluster example
• Structure the files as per https://developer.hashicorp.com/terraform/language/modules/develop/structure

Is your feature request related to a problem? Please describe.
Update the root readme.md file with examples for a better overview of the repository.

Describe the solution you'd like
Maintain readme file with terraform-docs utility

Update CHANGELOG.md with the latest release

Describe the bug

• The create_encryption_kms_key required variable is mentioned as optional in README
• The role_arn optional variable is mentioned in the description as required but is optional.
• Multiple variable descriptions have (optional) repeated.
• After updating the variables update the README file.

Describe the bug

The readme usage code snippet does not work because of the incorrect source URL
currently using local source URL, needs to replace with git URL.

module "public_eks" {
  source = "../../../"
[......]

to

module "eks" {
  source = "github.com/ishuar/terraform-eks"
[......]

Expected behavior

Module usage example in root readme should work without any adjustments to the module and interface.

Describe the bug

The default value of the EKS cluster version in the module is set to null which means the latest available version at resource creation is used and no upgrades will occur except those automatically triggered by EKS. which could cause drift in the deployment after some time and also results in issues [if not tracked] where old APIs were deprecated in the new EKS versions by AWS.

Solution

To Make it more obvious pin all examples with the cluster_version variable value. Recommended cluster_version is the current default Kubernetes version value provided by AWS.

1.24 as of now.

Need to add outputs for the eks open-id connect provider

• arn
• issuer

Is your feature request related to a problem? Please describe.
How to deploy and manage aws-load-balancer-controller with EKS

• Should automate the DNS resolution
• Should utilize ACM managed Certs
• Working example of a web service utilizing the underlying infrastructure

Additional context

• aws-load-balancer-controller

Currently, in the private eks example, node groups are using m5.large instance type for node group nodes.

• Change it to t3.medium for saving test costs.

• remove variable cluster_security_group_additional_rules as it is not being used anywhere in the module and the additional security group is created outside of the module.

Is your feature request related to a problem? Please describe.
Enabled checks for terraform fmt before merging.

Describe the solution you'd like

• utilize https://github.com/dflook/terraform-fmt-check and mark it as required check.

Submodules feature to support more examples with better structure and easy-to-follow code.

• By using submodules. users can avoid many configurations in their local environment and simplify the deployment workflow.

• Root README usage is incorrect , missing source attribute for module.
  • Subnets examples can be generalized with subnet_ids = ["subnet-abcde012", "subnet-bcde012a"]
• applying-the-configuration section of example cluster_with_alb is missing eks directory in sample command cd examples/cluster_with_alb
  • Fix Typos and sentence framing.

• Remove state config from examples

  • private_cluster
  • cluster_with_alb

• Update Source URLs

  • private_cluster
  • cluster_with_alb/eks/

• Alternate for Public SSH key or Ignore as the instance is SSM accessible in private_cluster

Need to update project readme with latest release v1.4.0 with examples and submodules.

• In external-dns-iam.tf

  • Top comments are not relevant. No policy exists for external DNS in the policies directory.
  • Incorrect Heading for IAM policy document resource.

• in exxternal-dns-service-account.tf

  • Update the name of file from exxternal-dns-service-account.tf to external-dns-service-account.tf : Typo
  • Header comment is incorrect.

To generate better GitHub release notes.

Use automatically-generated-release-notes