iscoder / io2011-opengl-for-android Goto Github PK

in chrome/common/extensions/extension_file_util.cc

bool ValidateExtension(const Extension* extension, std::string* error) {
  //ommision 
  // Theme resource validation.
  if (extension->is_theme()) {
    DictionaryValue* images_value = extension->GetThemeImages();
    if (images_value) {
      for (DictionaryValue::key_iterator iter = images_value->begin_keys();
           iter != images_value->end_keys(); ++iter) {
        std::string val;
        if (images_value->GetStringWithoutPathExpansion(*iter, &val)) {
          FilePath image_path = extension->path().AppendASCII(val); //bug
          if (!file_util::PathExists(image_path)) {
            *error =
                l10n_util::GetStringFUTF8(IDS_EXTENSION_INVALID_IMAGE_PATH,
                                          image_path.LossyDisplayName());
            return false;
          }
        }
      }
    }

    // Themes cannot contain other extension types.
    return true;
  }
notice  FilePath image_path = extension->path().AppendASCII(val); is wrong,when 
val is Ascian language string(for example, path has Chinese character).It make 
the following call "!file_util::PathExists(image_path)" return false. the 
correct code would like
FilePath image_path = extension->path().Append(UTF8ToUTF16(val));