Git Product home page Git Product logo

Comments (6)

othiym23 avatar othiym23 commented on August 25, 2024

npm uses node-tar, and has specific edge cases that specifically depend on node-tar's specific traits. Until we have the time to ensure that the move to tar-stream doesn't break npm, and shepherd through any necessary changes to tar-stream to get the specific edge cases we need handled (mostly around extended attributes and platform differences), npm will continue to use node-tar.

from node-tar.

fresheneesz avatar fresheneesz commented on August 25, 2024

@othiym23 Fair enough, but can we leave this issue open to record that we may want to go through that process?

from node-tar.

rlidwka avatar rlidwka commented on August 25, 2024

As far as I know, npm is able to install from any tarball, and any modern tar implementation should unpack npm tarballs. So what edge cases are there?

According to the benchmarks, it's also 10 times faster. I'd say it's reason enough to switch, especially because unpacking could be the slowest part of the install.

from node-tar.

edef1c avatar edef1c commented on August 25, 2024

@rlidwka That's an underestimation of the weird edge cases node-tar handles. We don't use tar(1) even if it's available for the same reasons.

from node-tar.

othiym23 avatar othiym23 commented on August 25, 2024

Extended attributes, custom headers, ACLs – if you've ever heard @isaacs talk about the time he put into getting node-tar right, you know that it was a major labor of passion for him. I really can't see npm switching without there being some kind of conformance suite we can put both tar-stream and node-tar through to compare how they handle weird situations on all of the OSes that npm supports.

from node-tar.

fresheneesz avatar fresheneesz commented on August 25, 2024

I would imagine node-tar's tests might be such a conformance suite? Then again, I have no concept of how much isaacs believes in unit-testing.

from node-tar.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.