Comments (6)
npm uses node-tar
, and has specific edge cases that specifically depend on node-tar
's specific traits. Until we have the time to ensure that the move to tar-stream
doesn't break npm, and shepherd through any necessary changes to tar-stream
to get the specific edge cases we need handled (mostly around extended attributes and platform differences), npm will continue to use node-tar
.
from node-tar.
@othiym23 Fair enough, but can we leave this issue open to record that we may want to go through that process?
from node-tar.
As far as I know, npm is able to install from any tarball, and any modern tar implementation should unpack npm tarballs. So what edge cases are there?
According to the benchmarks, it's also 10 times faster. I'd say it's reason enough to switch, especially because unpacking could be the slowest part of the install.
from node-tar.
@rlidwka That's an underestimation of the weird edge cases node-tar handles. We don't use tar(1) even if it's available for the same reasons.
from node-tar.
Extended attributes, custom headers, ACLs – if you've ever heard @isaacs talk about the time he put into getting node-tar
right, you know that it was a major labor of passion for him. I really can't see npm switching without there being some kind of conformance suite we can put both tar-stream and node-tar through to compare how they handle weird situations on all of the OSes that npm supports.
from node-tar.
I would imagine node-tar's tests might be such a conformance suite? Then again, I have no concept of how much isaacs believes in unit-testing.
from node-tar.
Related Issues (20)
- Error crashing my service HOT 4
- Error when using in typescript HOT 1
- [BUG] Crash when extracting file with hardlink to itself HOT 1
- Does not throw an error if the user does not have write permission to directory `cwd` HOT 2
- Enhancement: migrate yallist to js-sdsl HOT 1
- ASAR problem in Electron HOT 5
- After using node-tar to read a specific file in the tar package, the file cannot be deleted by fs.unlinkSync immediately. HOT 1
- tar seems to corrupt mac app bundle signature integrity HOT 4
- [Bug] path-reservations accessing index of undefined array HOT 1
- CHANGELOG.md missing entries HOT 13
- [7.0.0][type regression] Unpack is not assignable to NodeJS.WritableStream HOT 11
- v7 breaks sinon stubbing HOT 4
- unpack strip error HOT 3
- [7.0.1][Type Regression] Property 'write' in type 'Pack' is not assignable to the same property in base type 'Minipass<Buffer, ContiguousData>'. HOT 3
- Documentation: including multiple unrelated directories without leading directory elements in a single archive HOT 1
- Typescript issues for `Pack` and base type `Minipass<ContiguousData, Buffer, WarnEvent>` when using node v18 types HOT 6
- Node help
- Typescript issues for Pack and base type Minipass<ContiguousData, Buffer, WarnEvent> when using node v18 types HOT 3
- Incompatible TS types `Pack` and `Minipass<...>` HOT 4
- Compilation error for CommonJs modules HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from node-tar.