v7 breaks sinon stubbing about node-tar HOT 4 OPEN

Thanks! The following does appear to at least pass unit tests again:

// code:
const extract = require('tar/extract')
return extract.extract(options)

// test:
const extract = require('tar/extract')
const extractStub = sinon.stub(extract, 'extract')

from node-tar.

x is now a getter, because the codebase uses typescript and native esm, and live bindings need to work (even when transpiled to commonjs).

possible workarounds:

• require('tar/extract') directly in your code and mock the extract method.
• mock the fn on your end that calls tar.

from node-tar.

Thanks for the quick response. I did try changing my code to call tar.extract insted of tar.x but this cannot be stubbed by sinon, doing a sinon.stub(tar, 'extract') results in TypeError: Descriptor for property extract is non-configurable and non-writable.
If I require('tar/extract') I don't see how I would stub that with sinon.

from node-tar.

Rather than requiring tar in the implementation, require tar/extract and use the extract fn exported from that module.

Do the same where you mock. That module directly exports the fn extract, meaning it can be mocked, as it's not a getter.

from node-tar.